From: David Miller <davem@davemloft.net>
To: johunt@akamai.com
Cc: netdev@vger.kernel.org, edumazet@google.com, willemb@google.com,
alexander.h.duyck@intel.com
Subject: Re: [PATCH net v2 1/2] udp: fix gso_segs calculations
Date: Thu, 03 Oct 2019 11:49:52 -0400 (EDT) [thread overview]
Message-ID: <20191003.114952.2201613708507386478.davem@davemloft.net> (raw)
In-Reply-To: <1570037363-12485-1-git-send-email-johunt@akamai.com>
From: Josh Hunt <johunt@akamai.com>
Date: Wed, 2 Oct 2019 13:29:22 -0400
> Commit dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload")
> added gso_segs calculation, but incorrectly got sizeof() the pointer and
> not the underlying data type. In addition let's fix the v6 case.
>
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> Fixes: dfec0ee22c0a ("udp: Record gso_segs when supporting UDP segmentation offload")
> Signed-off-by: Josh Hunt <johunt@akamai.com>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Acked-by: Willem de Bruijn <willemb@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-10-03 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 17:29 [PATCH net v2 1/2] udp: fix gso_segs calculations Josh Hunt
2019-10-02 17:29 ` [PATCH net v2 2/2] udp: only do GSO if # of segs > 1 Josh Hunt
2019-10-02 20:41 ` Willem de Bruijn
2019-10-02 21:11 ` Duyck, Alexander H
2019-10-03 15:50 ` David Miller
2019-10-03 15:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003.114952.2201613708507386478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=edumazet@google.com \
--cc=johunt@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).