* [PATCH] igmp: uninline ip_mc_validate_checksum()
@ 2019-10-03 21:26 Alexey Dobriyan
2019-10-04 21:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2019-10-03 21:26 UTC (permalink / raw)
To: davem; +Cc: netdev
This function is only used via function pointer.
"inline" doesn't hurt given that taking address of an inline function
forces out-of-line version but it doesn't help either.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
net/ipv4/igmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1563,7 +1563,7 @@ static int ip_mc_check_igmp_msg(struct sk_buff *skb)
}
}
-static inline __sum16 ip_mc_validate_checksum(struct sk_buff *skb)
+static __sum16 ip_mc_validate_checksum(struct sk_buff *skb)
{
return skb_checksum_simple_validate(skb);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] igmp: uninline ip_mc_validate_checksum()
2019-10-03 21:26 [PATCH] igmp: uninline ip_mc_validate_checksum() Alexey Dobriyan
@ 2019-10-04 21:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-04 21:29 UTC (permalink / raw)
To: adobriyan; +Cc: netdev
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 4 Oct 2019 00:26:52 +0300
> This function is only used via function pointer.
>
> "inline" doesn't hurt given that taking address of an inline function
> forces out-of-line version but it doesn't help either.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-04 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 21:26 [PATCH] igmp: uninline ip_mc_validate_checksum() Alexey Dobriyan
2019-10-04 21:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).