* [PATCH] net: dsa: sja1105: Make function sja1105_xfer_long_buf static
@ 2019-10-04 9:57 zhengbin
2019-10-05 0:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-10-04 9:57 UTC (permalink / raw)
To: olteanv, andrew, vivien.didelot, f.fainelli, davem, netdev; +Cc: zhengbin13
Fix sparse warnings:
drivers/net/dsa/sja1105/sja1105_spi.c:159:5: warning: symbol 'sja1105_xfer_long_buf' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/dsa/sja1105/sja1105_spi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_spi.c b/drivers/net/dsa/sja1105/sja1105_spi.c
index 4688467..b224b1a 100644
--- a/drivers/net/dsa/sja1105/sja1105_spi.c
+++ b/drivers/net/dsa/sja1105/sja1105_spi.c
@@ -156,9 +156,9 @@ int sja1105_xfer_u32(const struct sja1105_private *priv,
* must be sent/received. Splitting the buffer into chunks and assembling
* those into SPI messages is done automatically by this function.
*/
-int sja1105_xfer_long_buf(const struct sja1105_private *priv,
- sja1105_spi_rw_mode_t rw, u64 base_addr,
- void *packed_buf, u64 buf_len)
+static int sja1105_xfer_long_buf(const struct sja1105_private *priv,
+ sja1105_spi_rw_mode_t rw, u64 base_addr,
+ void *packed_buf, u64 buf_len)
{
struct chunk {
void *buf_ptr;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: sja1105: Make function sja1105_xfer_long_buf static
2019-10-04 9:57 [PATCH] net: dsa: sja1105: Make function sja1105_xfer_long_buf static zhengbin
@ 2019-10-05 0:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-05 0:25 UTC (permalink / raw)
To: zhengbin13; +Cc: olteanv, andrew, vivien.didelot, f.fainelli, netdev
From: zhengbin <zhengbin13@huawei.com>
Date: Fri, 4 Oct 2019 17:57:30 +0800
> Fix sparse warnings:
>
> drivers/net/dsa/sja1105/sja1105_spi.c:159:5: warning: symbol 'sja1105_xfer_long_buf' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-05 0:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 9:57 [PATCH] net: dsa: sja1105: Make function sja1105_xfer_long_buf static zhengbin
2019-10-05 0:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).