* [PATCH] net: qlogic: Fix memory leak in ql_alloc_large_buffers
@ 2019-10-04 20:24 Navid Emamdoost
2019-10-05 1:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Navid Emamdoost @ 2019-10-04 20:24 UTC (permalink / raw)
Cc: emamd001, kjlu, smccaman, Navid Emamdoost, GR-Linux-NIC-Dev,
David S. Miller, netdev, linux-kernel
In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb.
This skb should be released if pci_dma_mapping_error fails.
Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 457444894d80..b4b8ba00ee01 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2787,6 +2787,7 @@ static int ql_alloc_large_buffers(struct ql3_adapter *qdev)
netdev_err(qdev->ndev,
"PCI mapping failed with error: %d\n",
err);
+ dev_kfree_skb_irq(skb);
ql_free_large_buffers(qdev);
return -ENOMEM;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qlogic: Fix memory leak in ql_alloc_large_buffers
2019-10-04 20:24 [PATCH] net: qlogic: Fix memory leak in ql_alloc_large_buffers Navid Emamdoost
@ 2019-10-05 1:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-05 1:35 UTC (permalink / raw)
To: navid.emamdoost
Cc: emamd001, kjlu, smccaman, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Navid Emamdoost <navid.emamdoost@gmail.com>
Date: Fri, 4 Oct 2019 15:24:39 -0500
> In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb.
> This skb should be released if pci_dma_mapping_error fails.
>
> Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-05 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 20:24 [PATCH] net: qlogic: Fix memory leak in ql_alloc_large_buffers Navid Emamdoost
2019-10-05 1:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).