Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] net: stmmac: Remove break after a return
@ 2019-10-09 14:29 Tiezhu Yang
  2019-10-10  4:13 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2019-10-09 14:29 UTC (permalink / raw)
  To: davem, peppe.cavallaro, alexandre.torgue, joabreu; +Cc: netdev, linux-kernel

Since break is not useful after a return, remove it.

Fixes: 3b57de958e2a ("net: stmmac: Support devicetree configs for mcast and ucast filter entries")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index 3d69da1..d0356fb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -130,7 +130,6 @@ static void dwmac1000_set_mchash(void __iomem *ioaddr, u32 *mcfilterbits,
 		writel(mcfilterbits[0], ioaddr + GMAC_HASH_LOW);
 		writel(mcfilterbits[1], ioaddr + GMAC_HASH_HIGH);
 		return;
-		break;
 	case 7:
 		numhashregs = 4;
 		break;
@@ -140,7 +139,6 @@ static void dwmac1000_set_mchash(void __iomem *ioaddr, u32 *mcfilterbits,
 	default:
 		pr_debug("STMMAC: err in setting multicast filter\n");
 		return;
-		break;
 	}
 	for (regs = 0; regs < numhashregs; regs++)
 		writel(mcfilterbits[regs],
-- 
2.1.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: stmmac: Remove break after a return
  2019-10-09 14:29 [PATCH] net: stmmac: Remove break after a return Tiezhu Yang
@ 2019-10-10  4:13 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2019-10-10  4:13 UTC (permalink / raw)
  To: Tiezhu Yang
  Cc: davem, peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-kernel

On Wed,  9 Oct 2019 22:29:00 +0800, Tiezhu Yang wrote:
> Since break is not useful after a return, remove it.
> 
> Fixes: 3b57de958e2a ("net: stmmac: Support devicetree configs for mcast and ucast filter entries")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 14:29 [PATCH] net: stmmac: Remove break after a return Tiezhu Yang
2019-10-10  4:13 ` Jakub Kicinski

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox