* [PATCH] net: lpc_eth: avoid resetting twice
@ 2019-10-10 20:46 Alexandre Belloni
2019-10-13 18:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2019-10-10 20:46 UTC (permalink / raw)
To: David S . Miller
Cc: Vladimir Zapolskiy, Sylvain Lemieux, netdev, linux-kernel,
linux-arm-kernel, Alexandre Belloni
__lpc_eth_shutdown is called after __lpc_eth_reset but it is already
calling __lpc_eth_reset. Avoid resetting the IP twice.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/net/ethernet/nxp/lpc_eth.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index fdcaf70151d4..e766a3e34d14 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -1364,9 +1364,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
if (!is_valid_ether_addr(ndev->dev_addr))
eth_hw_addr_random(ndev);
- /* Reset the ethernet controller */
- __lpc_eth_reset(pldat);
-
/* then shut everything down to save power */
__lpc_eth_shutdown(pldat);
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: lpc_eth: avoid resetting twice
2019-10-10 20:46 [PATCH] net: lpc_eth: avoid resetting twice Alexandre Belloni
@ 2019-10-13 18:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-13 18:15 UTC (permalink / raw)
To: alexandre.belloni
Cc: vz, slemieux.tyco, netdev, linux-kernel, linux-arm-kernel
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Thu, 10 Oct 2019 22:46:06 +0200
> __lpc_eth_shutdown is called after __lpc_eth_reset but it is already
> calling __lpc_eth_reset. Avoid resetting the IP twice.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-13 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 20:46 [PATCH] net: lpc_eth: avoid resetting twice Alexandre Belloni
2019-10-13 18:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).