Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue

Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue

[Stephen Hemminger]

Begin forwarded message:

Date: Wed, 16 Oct 2019 18:57:44 +0000
From: bugzilla-daemon@bugzilla.kernel.org
To: stephen@networkplumber.org
Subject: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue


https://bugzilla.kernel.org/show_bug.cgi?id=205215

            Bug ID: 205215
           Summary: Amiga X5000 Cyrus board DPAA network driver issue
           Product: Networking
           Version: 2.5
    Kernel Version: 5.4
          Hardware: PPC-32
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: IPV4
          Assignee: stephen@networkplumber.org
          Reporter: madskateman@gmail.com
        Regression: No

Hi all,

It might or might not be a bug, but help would be very welcome. 

Me and all other AmigaOne X5000 users (Cyrus mainboard with Freescale P5020
cpu) are not able to use the DPAA onboard Ethernet adapter with the linux
kernels since the last two years (AFAIK)
(link to the board: http://wiki.amiga.org/index.php?title=X5000 )

So what is happening,

First of all the hardware is functional. When using AmigaOS4.1FE the Ethernet
adapter is fine. When using the adapter within U-boot (ping for example) it is
also working as expected.

When booted into linux the ethernet adapter does not get up. 
The output of DMESG is:

skateman@X5000LNX:~$ dmesg | grep eth
[ 4.740603] fsl_dpaa_mac ffe4e6000.ethernet: FMan dTSEC version: 0x08240101
[ 4.741026] fsl_dpaa_mac ffe4e6000.ethernet: FMan MAC address:
00:04:a3:6b:41:7c
[ 4.741387] fsl_dpaa_mac ffe4e8000.ethernet: FMan dTSEC version: 0x08240101
[ 4.741740] fsl_dpaa_mac ffe4e8000.ethernet: FMan MAC address:
00:1e:c0:f8:31:b5
[ 4.742001] fsl_dpaa_mac ffe4e0000.ethernet:
of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e0000) failed
[ 4.742203] fsl_dpaa_mac: probe of ffe4e0000.ethernet failed with error -22
[ 4.742382] fsl_dpaa_mac ffe4e2000.ethernet:
of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e2000) failed
[ 4.742568] fsl_dpaa_mac: probe of ffe4e2000.ethernet failed with error -22
[ 4.742749] fsl_dpaa_mac ffe4e4000.ethernet:
of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e4000) failed
[ 4.747328] fsl_dpaa_mac: probe of ffe4e4000.ethernet failed with error -22
[ 4.751918] fsl_dpaa_mac ffe4f0000.ethernet:
of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@f0000) failed
[ 4.756660] fsl_dpaa_mac: probe of ffe4f0000.ethernet failed with error -22
[ 4.763988] fsl_dpaa_mac ffe4e6000.ethernet eth0: Probed interface eth0
[ 4.771622] fsl_dpaa_mac ffe4e8000.ethernet eth1: Probed interface eth1

There has been already spend time and effort but the issues still remains..
(
http://linuxppc.10917.n7.nabble.com/DPAA-Ethernet-traffice-troubles-with-Linux-kernel-td132277.html
)

I might have found something that could point into the right direction.

The last few days regarding another issue i stumbled upon this post from Russel
King. It had to do with coherent DMA
(http://forum.hyperion-entertainment.com/viewtopic.php?f=58&t=4349&start=70)

"Hmm, so it looks like PowerPC doesn't mark devices that are dma
coherent with a property that describes them as such.

I think this opens a wider question - what should of_dma_is_coherent()
return for PowerPC? It seems right now that it returns false for
devices that are DMA coherent, which seems to me to be a recipe for
future mistakes.

Any ideas from the PPC maintainers?"

I started to dig around regarding DPAA ethernet and Coherent DMA and stumbled
upon this document. 

http://cache.freescale.com/files/training/doc/ftf/2014/FTF-NET-F0246.pdf

In this troubleshooting document similar issues and errors are being shown with
possible troubleshooting steps. 

It would be great if someone could point us into the right direction and has a
clue what could be changed within the kernel to get the Ethernet adapter
working.

Dave

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue

[Maxim Uvarov]

чт, 17 окт. 2019 г. в 20:27, Stephen Hemminger <stephen@networkplumber.org>:
>
>
>
> Begin forwarded message:
>
> Date: Wed, 16 Oct 2019 18:57:44 +0000
> From: bugzilla-daemon@bugzilla.kernel.org
> To: stephen@networkplumber.org
> Subject: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=205215
>
>             Bug ID: 205215
>            Summary: Amiga X5000 Cyrus board DPAA network driver issue
>            Product: Networking
>            Version: 2.5
>     Kernel Version: 5.4
>           Hardware: PPC-32
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: IPV4
>           Assignee: stephen@networkplumber.org
>           Reporter: madskateman@gmail.com
>         Regression: No
>
> Hi all,
>
> It might or might not be a bug, but help would be very welcome.
>
> Me and all other AmigaOne X5000 users (Cyrus mainboard with Freescale P5020
> cpu) are not able to use the DPAA onboard Ethernet adapter with the linux
> kernels since the last two years (AFAIK)
> (link to the board: http://wiki.amiga.org/index.php?title=X5000 )
>
> So what is happening,
>
> First of all the hardware is functional. When using AmigaOS4.1FE the Ethernet
> adapter is fine. When using the adapter within U-boot (ping for example) it is
> also working as expected.
>
> When booted into linux the ethernet adapter does not get up.
> The output of DMESG is:
>
> skateman@X5000LNX:~$ dmesg | grep eth
> [ 4.740603] fsl_dpaa_mac ffe4e6000.ethernet: FMan dTSEC version: 0x08240101
> [ 4.741026] fsl_dpaa_mac ffe4e6000.ethernet: FMan MAC address:
> 00:04:a3:6b:41:7c
> [ 4.741387] fsl_dpaa_mac ffe4e8000.ethernet: FMan dTSEC version: 0x08240101
> [ 4.741740] fsl_dpaa_mac ffe4e8000.ethernet: FMan MAC address:
> 00:1e:c0:f8:31:b5
> [ 4.742001] fsl_dpaa_mac ffe4e0000.ethernet:
> of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e0000) failed

sound like mac is missing in dt.

> [ 4.742203] fsl_dpaa_mac: probe of ffe4e0000.ethernet failed with error -22
> [ 4.742382] fsl_dpaa_mac ffe4e2000.ethernet:
> of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e2000) failed
> [ 4.742568] fsl_dpaa_mac: probe of ffe4e2000.ethernet failed with error -22
> [ 4.742749] fsl_dpaa_mac ffe4e4000.ethernet:
> of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e4000) failed
> [ 4.747328] fsl_dpaa_mac: probe of ffe4e4000.ethernet failed with error -22
> [ 4.751918] fsl_dpaa_mac ffe4f0000.ethernet:
> of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@f0000) failed
> [ 4.756660] fsl_dpaa_mac: probe of ffe4f0000.ethernet failed with error -22
> [ 4.763988] fsl_dpaa_mac ffe4e6000.ethernet eth0: Probed interface eth0
> [ 4.771622] fsl_dpaa_mac ffe4e8000.ethernet eth1: Probed interface eth1
>
> There has been already spend time and effort but the issues still remains..
> (
> http://linuxppc.10917.n7.nabble.com/DPAA-Ethernet-traffice-troubles-with-Linux-kernel-td132277.html
> )
>
> I might have found something that could point into the right direction.
>
> The last few days regarding another issue i stumbled upon this post from Russel
> King. It had to do with coherent DMA
> (http://forum.hyperion-entertainment.com/viewtopic.php?f=58&t=4349&start=70)
>
> "Hmm, so it looks like PowerPC doesn't mark devices that are dma
> coherent with a property that describes them as such.
>
> I think this opens a wider question - what should of_dma_is_coherent()
> return for PowerPC? It seems right now that it returns false for
> devices that are DMA coherent, which seems to me to be a recipe for
> future mistakes.
>
> Any ideas from the PPC maintainers?"
>
> I started to dig around regarding DPAA ethernet and Coherent DMA and stumbled
> upon this document.
>
> http://cache.freescale.com/files/training/doc/ftf/2014/FTF-NET-F0246.pdf
>
> In this troubleshooting document similar issues and errors are being shown with
> possible troubleshooting steps.
>
> It would be great if someone could point us into the right direction and has a
> clue what could be changed within the kernel to get the Ethernet adapter
> working.
>
> Dave
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.



-- 
Best regards,
Maxim Uvarov

RE: Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network driver issue

[Madalin-cristian Bucur]

> -----Original Message-----
> From: Maxim Uvarov <muvarov@gmail.com>
> Sent: Friday, October 18, 2019 11:42 AM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Madalin-cristian Bucur <madalin.bucur@nxp.com>; netdev
> <netdev@vger.kernel.org>
> Subject: Re: Fw: [Bug 205215] New: Amiga X5000 Cyrus board DPAA network
> driver issue
> 
> чт, 17 окт. 2019 г. в 20:27, Stephen Hemminger
> <stephen@networkplumber.org>:
<snip>
> > So what is happening,
> >
> > First of all the hardware is functional. When using AmigaOS4.1FE the
> Ethernet
> > adapter is fine. When using the adapter within U-boot (ping for example)
> it is
> > also working as expected.
> >
> > When booted into linux the ethernet adapter does not get up.
> > The output of DMESG is:
> >
> > skateman@X5000LNX:~$ dmesg | grep eth
> > [ 4.740603] fsl_dpaa_mac ffe4e6000.ethernet: FMan dTSEC version:
> 0x08240101
> > [ 4.741026] fsl_dpaa_mac ffe4e6000.ethernet: FMan MAC address:
> > 00:04:a3:6b:41:7c
> > [ 4.741387] fsl_dpaa_mac ffe4e8000.ethernet: FMan dTSEC version:
> 0x08240101
> > [ 4.741740] fsl_dpaa_mac ffe4e8000.ethernet: FMan MAC address:
> > 00:1e:c0:f8:31:b5
> > [ 4.742001] fsl_dpaa_mac ffe4e0000.ethernet:
> > of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@e0000) failed
> 
> sound like mac is missing in dt.
> 

Indeed, if you do not set the required u-boot env entries, the MAC address
fixup of the device tree will not be performed and the driver will not 
probe those MACs. The question is - are the interfaces that do probe
functional?

Madalin