[PATCH net V2] Documentation: TLS: Add missing counter description

[PATCH net V2] Documentation: TLS: Add missing counter description

[Tariq Toukan]

Add TLS TX counter description for the handshake retransmitted
packets that triggers the resync procedure then skip it, going
into the regular transmit flow.

Fixes: 46a3ea98074e ("net/mlx5e: kTLS, Enhance TX resync flow")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
 Documentation/networking/tls-offload.rst | 4 ++++
 1 file changed, 4 insertions(+)

v1 -> v2: Fixed counter description, per Jakub's comment.

diff --git a/Documentation/networking/tls-offload.rst b/Documentation/networking/tls-offload.rst
index 0dd3f748239f..f914e81fd3a6 100644
--- a/Documentation/networking/tls-offload.rst
+++ b/Documentation/networking/tls-offload.rst
@@ -436,6 +436,10 @@ by the driver:
    encryption.
  * ``tx_tls_ooo`` - number of TX packets which were part of a TLS stream
    but did not arrive in the expected order.
+ * ``tx_tls_skip_no_sync_data`` - number of TX packets which were part of
+   a TLS stream and arrived out-of-order, but skipped the HW offload routine
+   and went to the regular transmit flow as they were retransmissions of the
+   connection handshake.
  * ``tx_tls_drop_no_sync_data`` - number of TX packets which were part of
    a TLS stream dropped, because they arrived out of order and associated
    record could not be found.
-- 
2.21.0

Re: [PATCH net V2] Documentation: TLS: Add missing counter description

[Jakub Kicinski]

On Tue,  5 Nov 2019 14:13:48 +0200, Tariq Toukan wrote:
> Add TLS TX counter description for the handshake retransmitted
> packets that triggers the resync procedure then skip it, going
> into the regular transmit flow.
> 
> Fixes: 46a3ea98074e ("net/mlx5e: kTLS, Enhance TX resync flow")
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

Good enough :) Since record sequence number is part of the state
installed in the kernel the pre-kTLS part of the connection doesn't
need to be part of the handshake, application can install the key at
any point in time. But in practice it's going to be handshake most of
the time, so perhaps that's more intuitive to understand for people.

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Re: [PATCH net V2] Documentation: TLS: Add missing counter description

[David Miller]

From: Tariq Toukan <tariqt@mellanox.com>
Date: Tue,  5 Nov 2019 14:13:48 +0200

> Add TLS TX counter description for the handshake retransmitted
> packets that triggers the resync procedure then skip it, going
> into the regular transmit flow.
> 
> Fixes: 46a3ea98074e ("net/mlx5e: kTLS, Enhance TX resync flow")
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

Applied