* [PATCH net-next] selftests: Add source route tests to fib_tests
@ 2019-11-07 18:32 David Ahern
2019-11-08 0:17 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2019-11-07 18:32 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
Add tests to verify routes with source address set are deleted when
source address is deleted.
Signed-off-by: David Ahern <dsahern@kernel.org>
---
tools/testing/selftests/net/fib_tests.sh | 52 +++++++++++++++++++++++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 76c1897e6352..dd35b7071b8b 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -9,7 +9,7 @@ ret=0
ksft_skip=4
# all tests in this script. Can be overridden with -t option
-TESTS="unregister down carrier nexthop suppress ipv6_rt ipv4_rt ipv6_addr_metric ipv4_addr_metric ipv6_route_metrics ipv4_route_metrics ipv4_route_v6_gw rp_filter"
+TESTS="unregister down carrier nexthop suppress ipv6_rt ipv4_rt ipv6_addr_metric ipv4_addr_metric ipv6_route_metrics ipv4_route_metrics ipv4_route_v6_gw rp_filter ipv4_del_addr"
VERBOSE=0
PAUSE_ON_FAIL=no
@@ -1500,6 +1500,55 @@ ipv4_route_metrics_test()
route_cleanup
}
+ipv4_del_addr_test()
+{
+ echo
+ echo "IPv4 delete address route tests"
+
+ setup
+
+ set -e
+ $IP li add dummy1 type dummy
+ $IP li set dummy1 up
+ $IP li add dummy2 type dummy
+ $IP li set dummy2 up
+ $IP li add red type vrf table 1111
+ $IP li set red up
+ $IP ro add vrf red unreachable default
+ $IP li set dummy2 vrf red
+
+ $IP addr add dev dummy1 172.16.104.1/24
+ $IP addr add dev dummy1 172.16.104.11/24
+ $IP addr add dev dummy2 172.16.104.1/24
+ $IP addr add dev dummy2 172.16.104.11/24
+ $IP route add 172.16.105.0/24 via 172.16.104.2 src 172.16.104.11
+ $IP route add vrf red 172.16.105.0/24 via 172.16.104.2 src 172.16.104.11
+ set +e
+
+ # removing address from device in vrf should only remove route from vrf table
+ $IP addr del dev dummy2 172.16.104.11/24
+ $IP ro ls vrf red | grep -q 172.16.105.0/24
+ log_test $? 1 "Route removed from VRF when source address deleted"
+
+ $IP ro ls | grep -q 172.16.105.0/24
+ log_test $? 0 "Route in default VRF not removed"
+
+ $IP addr add dev dummy2 172.16.104.11/24
+ $IP route add vrf red 172.16.105.0/24 via 172.16.104.2 src 172.16.104.11
+
+ $IP addr del dev dummy1 172.16.104.11/24
+ $IP ro ls | grep -q 172.16.105.0/24
+ log_test $? 1 "Route removed in default VRF when source address deleted"
+
+ $IP ro ls vrf red | grep -q 172.16.105.0/24
+ log_test $? 0 "Route in VRF is not removed by address delete"
+
+ $IP li del dummy1
+ $IP li del dummy2
+ cleanup
+}
+
+
ipv4_route_v6_gw_test()
{
local rc
@@ -1633,6 +1682,7 @@ do
ipv4_route_test|ipv4_rt) ipv4_route_test;;
ipv6_addr_metric) ipv6_addr_metric_test;;
ipv4_addr_metric) ipv4_addr_metric_test;;
+ ipv4_del_addr) ipv4_del_addr_test;;
ipv6_route_metrics) ipv6_route_metrics_test;;
ipv4_route_metrics) ipv4_route_metrics_test;;
ipv4_route_v6_gw) ipv4_route_v6_gw_test;;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: Add source route tests to fib_tests
2019-11-07 18:32 [PATCH net-next] selftests: Add source route tests to fib_tests David Ahern
@ 2019-11-08 0:17 ` David Miller
2019-11-08 1:42 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2019-11-08 0:17 UTC (permalink / raw)
To: dsahern; +Cc: netdev
From: David Ahern <dsahern@kernel.org>
Date: Thu, 7 Nov 2019 18:32:32 +0000
> Add tests to verify routes with source address set are deleted when
> source address is deleted.
>
> Signed-off-by: David Ahern <dsahern@kernel.org>
...
> + $IP ro add vrf red unreachable default
^
Trailing whitespace which I fixed up.
Applied, thanks David.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: Add source route tests to fib_tests
2019-11-08 0:17 ` David Miller
@ 2019-11-08 1:42 ` David Ahern
0 siblings, 0 replies; 3+ messages in thread
From: David Ahern @ 2019-11-08 1:42 UTC (permalink / raw)
To: David Miller, dsahern; +Cc: netdev
On 11/7/19 5:17 PM, David Miller wrote:
> Trailing whitespace which I fixed up.
oops. A new setup and I forgot to setup the pre-commit hook to run
checkpatch. Will fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 18:32 [PATCH net-next] selftests: Add source route tests to fib_tests David Ahern
2019-11-08 0:17 ` David Miller
2019-11-08 1:42 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).