* [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support
@ 2019-11-07 23:27 Abhishek Pandit-Subedi
2019-11-07 23:27 ` [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config Abhishek Pandit-Subedi
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Pandit-Subedi @ 2019-11-07 23:27 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Rob Herring
Cc: linux-bluetooth, dianders, Abhishek Pandit-Subedi, devicetree,
David S. Miller, netdev, linux-kernel, Ondrej Jirman,
Mark Rutland, Chen-Yu Tsai
While adding support for the BCM4354, I discovered a few more things
that weren't working as they should have.
First, we disallow serdev from setting the baudrate on BCM4354. Serdev
sets the oper_speed first before calling hu->setup() in
hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing
when the hci reset times out.
Next, we add support for setting the PCM parameters, which consists of
a pair of vendor specific opcodes to set the pcm parameters. The
documentation for these params are available in the brcm_patchram_plus
package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is
necessary for PCM to work properly.
All changes were tested with rk3288-veyron-minnie.dts.
Changes in v2:
- Use match data to disallow baudrate setting
- Parse pcm parameters by name instead of as a byte string
- Fix prefix for dt-bindings commit
Abhishek Pandit-Subedi (4):
Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354
Bluetooth: btbcm: Support pcm configuration
Bluetooth: hci_bcm: Support pcm params in dts
dt-bindings: net: broadcom-bluetooth: Add pcm config
.../bindings/net/broadcom-bluetooth.txt | 11 ++++
drivers/bluetooth/btbcm.c | 35 +++++++++++
drivers/bluetooth/btbcm.h | 10 ++++
drivers/bluetooth/hci_bcm.c | 58 ++++++++++++++++++-
4 files changed, 112 insertions(+), 2 deletions(-)
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config
2019-11-07 23:27 [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Abhishek Pandit-Subedi
@ 2019-11-07 23:27 ` Abhishek Pandit-Subedi
2019-11-08 6:12 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Pandit-Subedi @ 2019-11-07 23:27 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Rob Herring
Cc: linux-bluetooth, dianders, Abhishek Pandit-Subedi, devicetree,
David S. Miller, netdev, linux-kernel, Ondrej Jirman,
Mark Rutland, Chen-Yu Tsai
Add documentation for pcm parameters.
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
---
Changes in v2:
- Use match data to disallow baudrate setting
- Parse pcm parameters by name instead of as a byte string
- Fix prefix for dt-bindings commit
.../devicetree/bindings/net/broadcom-bluetooth.txt | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
index c749dc297624..b5de8a6a3980 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
@@ -29,6 +29,11 @@ Optional properties:
- "lpo": external low power 32.768 kHz clock
- vbat-supply: phandle to regulator supply for VBAT
- vddio-supply: phandle to regulator supply for VDDIO
+ - brcm,sco-routing: 0-3 (PCM, Transport, Codec, I2S)
+ - brcm,pcm-interface-rate: 0-4 (128KBps, 256KBps, 512KBps, 1024KBps, 2048KBps)
+ - brcm,pcm-frame-type: 0-1 (short, long)
+ - brcm,pcm-sync-mode: 0-1 (slave, master)
+ - brcm,pcm-clock-mode: 0-1 (slave, master)
Example:
@@ -40,5 +45,11 @@ Example:
bluetooth {
compatible = "brcm,bcm43438-bt";
max-speed = <921600>;
+
+ brcm,sco-routing = [01];
+ brcm,pcm-interface-rate = [02];
+ brcm,pcm-frame-type = [00];
+ brcm,pcm-sync-mode = [01];
+ brcm,pcm-clock-mode = [01];
};
};
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config
2019-11-07 23:27 ` [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config Abhishek Pandit-Subedi
@ 2019-11-08 6:12 ` Marcel Holtmann
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2019-11-08 6:12 UTC (permalink / raw)
To: Abhishek Pandit-Subedi
Cc: Johan Hedberg, Rob Herring, linux-bluetooth, dianders,
devicetree, David S. Miller, netdev, linux-kernel, Ondrej Jirman,
Mark Rutland, Chen-Yu Tsai
Hi Abhishek,
> Add documentation for pcm parameters.
>
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> ---
>
> Changes in v2:
> - Use match data to disallow baudrate setting
> - Parse pcm parameters by name instead of as a byte string
> - Fix prefix for dt-bindings commit
>
> .../devicetree/bindings/net/broadcom-bluetooth.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> index c749dc297624..b5de8a6a3980 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> @@ -29,6 +29,11 @@ Optional properties:
> - "lpo": external low power 32.768 kHz clock
> - vbat-supply: phandle to regulator supply for VBAT
> - vddio-supply: phandle to regulator supply for VDDIO
> + - brcm,sco-routing: 0-3 (PCM, Transport, Codec, I2S)
> + - brcm,pcm-interface-rate: 0-4 (128KBps, 256KBps, 512KBps, 1024KBps, 2048KBps)
> + - brcm,pcm-frame-type: 0-1 (short, long)
> + - brcm,pcm-sync-mode: 0-1 (slave, master)
> + - brcm,pcm-clock-mode: 0-1 (slave, master)
should we do brcm,bt-sco-routing etc.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 6:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 23:27 [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Abhishek Pandit-Subedi
2019-11-07 23:27 ` [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config Abhishek Pandit-Subedi
2019-11-08 6:12 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).