* [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules
@ 2019-11-13 10:11 Aleksander Morgado
2019-11-13 10:27 ` Bjørn Mork
2019-11-13 19:59 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Aleksander Morgado @ 2019-11-13 10:11 UTC (permalink / raw)
To: bjorn, davem, netdev, linux-usb; +Cc: Aleksander Morgado
These are the Foxconn-branded variants of the Dell DW5821e modules,
same USB layout as those.
The QMI interface is exposed in USB configuration #1:
P: Vendor=0489 ProdID=e0b4 Rev=03.18
S: Manufacturer=FII
S: Product=T77W968 LTE
S: SerialNumber=0123456789ABCDEF
C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
I: If#=0x1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid
I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
drivers/net/usb/qmi_wwan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 56d334b9ad45..4196c0e32740 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1371,6 +1371,8 @@ static const struct usb_device_id products[] = {
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
{QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */
+ {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)}, /* Foxconn T77W968 LTE */
+ {QMI_FIXED_INTF(0x0489, 0xe0b5, 0)}, /* Foxconn T77W968 LTE with eSIM support*/
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules
2019-11-13 10:11 [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules Aleksander Morgado
@ 2019-11-13 10:27 ` Bjørn Mork
2019-11-13 12:06 ` Aleksander Morgado
2019-11-13 19:59 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Bjørn Mork @ 2019-11-13 10:27 UTC (permalink / raw)
To: Aleksander Morgado; +Cc: davem, netdev, linux-usb
Aleksander Morgado <aleksander@aleksander.es> writes:
> These are the Foxconn-branded variants of the Dell DW5821e modules,
> same USB layout as those.
>
> The QMI interface is exposed in USB configuration #1:
>
> P: Vendor=0489 ProdID=e0b4 Rev=03.18
> S: Manufacturer=FII
> S: Product=T77W968 LTE
> S: SerialNumber=0123456789ABCDEF
> C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I: If#=0x1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid
> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
> drivers/net/usb/qmi_wwan.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 56d334b9ad45..4196c0e32740 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1371,6 +1371,8 @@ static const struct usb_device_id products[] = {
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
> {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
> {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */
> + {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)}, /* Foxconn T77W968 LTE */
> + {QMI_FIXED_INTF(0x0489, 0xe0b5, 0)}, /* Foxconn T77W968 LTE with eSIM support*/
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Acked-by: Bjørn Mork <bjorn@mork.no>
Just one question, which I should have asked about the DW5821e too: Is
it possible to configure the firmware of these modems to USB2 only, and
do they work with the qmi_wwan driver then?
I suspect that these modems really need the SET_DTR quirk... Or rather
that I should get around to making that default, as it seems most new
stuff needs it and most old stuff doesn't care.
Bjørn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules
2019-11-13 10:27 ` Bjørn Mork
@ 2019-11-13 12:06 ` Aleksander Morgado
0 siblings, 0 replies; 4+ messages in thread
From: Aleksander Morgado @ 2019-11-13 12:06 UTC (permalink / raw)
To: Bjørn Mork; +Cc: David S. Miller, netdev, linux-usb
> Just one question, which I should have asked about the DW5821e too: Is
> it possible to configure the firmware of these modems to USB2 only, and
> do they work with the qmi_wwan driver then?
>
I know these modules force a USB 2.0-only mode when they switch to
fastboot to allow firmware upgrade, but there is no way to configure
the firmware to boot into USB 2.0-only mode while in modem mode.
--
Aleksander
https://aleksander.es
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules
2019-11-13 10:11 [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules Aleksander Morgado
2019-11-13 10:27 ` Bjørn Mork
@ 2019-11-13 19:59 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-11-13 19:59 UTC (permalink / raw)
To: aleksander; +Cc: bjorn, netdev, linux-usb
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Wed, 13 Nov 2019 11:11:10 +0100
> These are the Foxconn-branded variants of the Dell DW5821e modules,
> same USB layout as those.
>
> The QMI interface is exposed in USB configuration #1:
>
> P: Vendor=0489 ProdID=e0b4 Rev=03.18
> S: Manufacturer=FII
> S: Product=T77W968 LTE
> S: SerialNumber=0123456789ABCDEF
> C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I: If#=0x1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid
> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-13 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 10:11 [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules Aleksander Morgado
2019-11-13 10:27 ` Bjørn Mork
2019-11-13 12:06 ` Aleksander Morgado
2019-11-13 19:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).