* [PATCH net-next] cxgb4: Fix an error code in cxgb4_mqprio_alloc_hw_resources()
@ 2019-11-13 18:25 Dan Carpenter
2019-11-13 22:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-11-13 18:25 UTC (permalink / raw)
To: Vishal Kulkarni, Rahul Lakkireddy
Cc: David S. Miller, netdev, kernel-janitors
"ret" is zero or possibly uninitialized on this error path. It
should be a negative error code instead.
Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
index 143cb1f31bc0..eee45edc59e7 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
@@ -158,8 +158,10 @@ static int cxgb4_mqprio_alloc_hw_resources(struct net_device *dev)
/* Allocate Rxqs for receiving ETHOFLD Tx completions */
if (msix >= 0) {
msix = cxgb4_get_msix_idx_from_bmap(adap);
- if (msix < 0)
+ if (msix < 0) {
+ ret = msix;
goto out_free_queues;
+ }
eorxq->msix = &adap->msix_info[msix];
snprintf(eorxq->msix->desc,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cxgb4: Fix an error code in cxgb4_mqprio_alloc_hw_resources()
2019-11-13 18:25 [PATCH net-next] cxgb4: Fix an error code in cxgb4_mqprio_alloc_hw_resources() Dan Carpenter
@ 2019-11-13 22:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-13 22:38 UTC (permalink / raw)
To: dan.carpenter; +Cc: vishal, rahul.lakkireddy, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 13 Nov 2019 21:25:48 +0300
> "ret" is zero or possibly uninitialized on this error path. It
> should be a negative error code instead.
>
> Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 18:25 [PATCH net-next] cxgb4: Fix an error code in cxgb4_mqprio_alloc_hw_resources() Dan Carpenter
2019-11-13 22:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).