netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: phy: Use the correct style for SPDX License Identifier
@ 2019-11-23 13:08 Nishad Kamdar
  2019-11-24  2:34 ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Nishad Kamdar @ 2019-11-23 13:08 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller,
	Maxime Coquelin, Greg Kroah-Hartman, Joe Perches,
	Uwe Kleine-König
  Cc: netdev, linux-kernel

This patch corrects the SPDX License Identifier style in
header files related to PHY Layer for Ethernet drivers.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used). This patch also gives an explicit
block comment to the SPDX License Identifier.

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
 drivers/net/phy/aquantia.h    | 4 ++--
 drivers/net/phy/bcm-phy-lib.h | 2 +-
 drivers/net/phy/mdio-cavium.h | 2 +-
 drivers/net/phy/mdio-i2c.h    | 2 +-
 drivers/net/phy/mdio-xgene.h  | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
index 5a16caab7b2f..40e0be0f4e1c 100644
--- a/drivers/net/phy/aquantia.h
+++ b/drivers/net/phy/aquantia.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- * HWMON driver for Aquantia PHY
+/* SPDX-License-Identifier: GPL-2.0 */
+/*  HWMON driver for Aquantia PHY
  *
  * Author: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
  * Author: Andrew Lunn <andrew@lunn.ch>
diff --git a/drivers/net/phy/bcm-phy-lib.h b/drivers/net/phy/bcm-phy-lib.h
index 5ecacb4e64f0..c86fb9d1240c 100644
--- a/drivers/net/phy/bcm-phy-lib.h
+++ b/drivers/net/phy/bcm-phy-lib.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (C) 2015 Broadcom Corporation
  */
diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h
index b7f89ad27465..e33d3ea9a907 100644
--- a/drivers/net/phy/mdio-cavium.h
+++ b/drivers/net/phy/mdio-cavium.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (C) 2009-2016 Cavium, Inc.
  */
diff --git a/drivers/net/phy/mdio-i2c.h b/drivers/net/phy/mdio-i2c.h
index 751dab281f57..b1d27f7cd23f 100644
--- a/drivers/net/phy/mdio-i2c.h
+++ b/drivers/net/phy/mdio-i2c.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * MDIO I2C bridge
  *
diff --git a/drivers/net/phy/mdio-xgene.h b/drivers/net/phy/mdio-xgene.h
index b1f5ccb4ad9c..8af93ada8b64 100644
--- a/drivers/net/phy/mdio-xgene.h
+++ b/drivers/net/phy/mdio-xgene.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /* Applied Micro X-Gene SoC MDIO Driver
  *
  * Copyright (c) 2016, Applied Micro Circuits Corporation
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Use the correct style for SPDX License Identifier
  2019-11-23 13:08 [PATCH] net: phy: Use the correct style for SPDX License Identifier Nishad Kamdar
@ 2019-11-24  2:34 ` Jakub Kicinski
  2019-11-25 14:39   ` Nishad Kamdar
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2019-11-24  2:34 UTC (permalink / raw)
  To: Nishad Kamdar
  Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller,
	Maxime Coquelin, Greg Kroah-Hartman, Joe Perches,
	Uwe Kleine-König, netdev, linux-kernel

On Sat, 23 Nov 2019 18:38:19 +0530, Nishad Kamdar wrote:
> diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
> index 5a16caab7b2f..40e0be0f4e1c 100644
> --- a/drivers/net/phy/aquantia.h
> +++ b/drivers/net/phy/aquantia.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * HWMON driver for Aquantia PHY
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*  HWMON driver for Aquantia PHY

You're adding an extra space here. Is this intentional?

>   *
>   * Author: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
>   * Author: Andrew Lunn <andrew@lunn.ch>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Use the correct style for SPDX License Identifier
  2019-11-24  2:34 ` Jakub Kicinski
@ 2019-11-25 14:39   ` Nishad Kamdar
  0 siblings, 0 replies; 3+ messages in thread
From: Nishad Kamdar @ 2019-11-25 14:39 UTC (permalink / raw)
  To: Jakub Kicinski, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
	David S. Miller, Maxime Coquelin, Greg Kroah-Hartman,
	Joe Perches, Uwe Kleine-König
  Cc: netdev, linux-kernel

On Sat, Nov 23, 2019 at 06:34:55PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Nov 2019 18:38:19 +0530, Nishad Kamdar wrote:
> > diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
> > index 5a16caab7b2f..40e0be0f4e1c 100644
> > --- a/drivers/net/phy/aquantia.h
> > +++ b/drivers/net/phy/aquantia.h
> > @@ -1,5 +1,5 @@
> > -/* SPDX-License-Identifier: GPL-2.0
> > - * HWMON driver for Aquantia PHY
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*  HWMON driver for Aquantia PHY
> 
> You're adding an extra space here. Is this intentional?

No, It shouldn't be there.

Thanks you for pointing it out.
I'll update and resend the patch.

Thanks for the review.

Regards,
Nishad

> 
> >   *
> >   * Author: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> >   * Author: Andrew Lunn <andrew@lunn.ch>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-25 14:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23 13:08 [PATCH] net: phy: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-11-24  2:34 ` Jakub Kicinski
2019-11-25 14:39   ` Nishad Kamdar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).