* [PATCH net v4] net: macb: add missed tasklet_kill
@ 2019-11-28 2:00 Chuhong Yuan
2019-11-29 7:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-28 2:00 UTC (permalink / raw)
Cc: Nicolas Ferre, David S . Miller, netdev, linux-kernel, Chuhong Yuan
This driver forgets to kill tasklet in remove.
Add the call to fix it.
Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v4:
- Put tasklet_kill after unregister_netdev to ensure
IRQs are disabled when killing tasklet.
drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index d5ae2e1e0b0e..9c767ee252ac 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev)
mdiobus_free(bp->mii_bus);
unregister_netdev(dev);
+ tasklet_kill(&bp->hresp_err_tasklet);
pm_runtime_disable(&pdev->dev);
pm_runtime_dont_use_autosuspend(&pdev->dev);
if (!pm_runtime_suspended(&pdev->dev)) {
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v4] net: macb: add missed tasklet_kill
2019-11-28 2:00 [PATCH net v4] net: macb: add missed tasklet_kill Chuhong Yuan
@ 2019-11-29 7:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-29 7:06 UTC (permalink / raw)
To: hslester96; +Cc: nicolas.ferre, netdev, linux-kernel
From: Chuhong Yuan <hslester96@gmail.com>
Date: Thu, 28 Nov 2019 10:00:21 +0800
> This driver forgets to kill tasklet in remove.
> Add the call to fix it.
>
> Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v4:
> - Put tasklet_kill after unregister_netdev to ensure
> IRQs are disabled when killing tasklet.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-29 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 2:00 [PATCH net v4] net: macb: add missed tasklet_kill Chuhong Yuan
2019-11-29 7:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).