Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
@ 2019-12-02 14:11 Victorien Molle
  2019-12-02 15:18 ` Toke Høiland-Jørgensen
  2019-12-02 20:33 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Victorien Molle @ 2019-12-02 14:11 UTC (permalink / raw)
  To: netdev; +Cc: Victorien Molle, Florent Fourcot

This field has never been checked since introduction in mainline kernel

Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"
---
 net/sched/sch_cake.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 53a80bc6b13a..e0f40400f679 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -2184,6 +2184,7 @@ static const struct nla_policy cake_policy[TCA_CAKE_MAX + 1] = {
 	[TCA_CAKE_MPU]		 = { .type = NLA_U32 },
 	[TCA_CAKE_INGRESS]	 = { .type = NLA_U32 },
 	[TCA_CAKE_ACK_FILTER]	 = { .type = NLA_U32 },
+	[TCA_CAKE_SPLIT_GSO]	 = { .type = NLA_U32 },
 	[TCA_CAKE_FWMARK]	 = { .type = NLA_U32 },
 };
 
-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
  2019-12-02 14:11 [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO Victorien Molle
@ 2019-12-02 15:18 ` Toke Høiland-Jørgensen
  2019-12-02 20:33 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-12-02 15:18 UTC (permalink / raw)
  To: Victorien Molle, netdev; +Cc: Victorien Molle, Florent Fourcot

Victorien Molle <victorien.molle@wifirst.fr> writes:

> This field has never been checked since introduction in mainline kernel
>
> Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"

Don't suppose this is likely to break anything by stricter enforcement,
so:

Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
  2019-12-02 14:11 [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO Victorien Molle
  2019-12-02 15:18 ` Toke Høiland-Jørgensen
@ 2019-12-02 20:33 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-12-02 20:33 UTC (permalink / raw)
  To: victorien.molle; +Cc: netdev, florent.fourcot

From: Victorien Molle <victorien.molle@wifirst.fr>
Date: Mon,  2 Dec 2019 15:11:38 +0100

> This field has never been checked since introduction in mainline kernel
> 
> Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 14:11 [PATCH] sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO Victorien Molle
2019-12-02 15:18 ` Toke Høiland-Jørgensen
2019-12-02 20:33 ` David Miller

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git