netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: edumazet@google.com, netdev@vger.kernel.org,
	eric.dumazet@gmail.com, soheil@google.com, ncardwell@google.com,
	ycheng@google.com, willemb@google.com
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()
Date: Tue, 03 Dec 2019 13:18:44 -0800 (PST)	[thread overview]
Message-ID: <20191203.131844.1288568107728597971.davem@davemloft.net> (raw)
In-Reply-To: <20191203202358.GB3183510@kroah.com>

From: Greg KH <gregkh@linuxfoundation.org>
Date: Tue, 3 Dec 2019 21:23:58 +0100

> On Tue, Dec 03, 2019 at 11:53:11AM -0800, David Miller wrote:
>> From: Eric Dumazet <edumazet@google.com>
>> Date: Tue,  3 Dec 2019 08:05:52 -0800
>> 
>> > It appears linux-4.14 stable needs a backport of commit
>> > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
>> > 
>> > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
>> > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
>> > 
>> > I will provide to stable teams the squashed patches.
>> > 
>> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>> 
>> Applied, thanks Eric.
> 
> Applied where, do you have a 4.14-stable queue too?  :)

Applied to my net GIT tree, I do not have a 4.14 -stable queue :-)

> I can just take this directly to my 4.14.y tree now if you don't object.

Please integrate all of the -stable parts, yes.

Thanks.

      parent reply	other threads:[~2019-12-03 21:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 16:05 [PATCH net] tcp: refactor tcp_retransmit_timer() Eric Dumazet
2019-12-03 16:08 ` Soheil Hassas Yeganeh
2019-12-03 19:13 ` Greg Kroah-Hartman
2019-12-03 19:15   ` Eric Dumazet
2019-12-03 19:22     ` Greg Kroah-Hartman
2019-12-03 19:30       ` Eric Dumazet
2019-12-03 20:23         ` Greg Kroah-Hartman
2019-12-03 19:53 ` David Miller
2019-12-03 20:23   ` Greg KH
     [not found]     ` <CANn89iKP7EZZRBtdcvFZVWP5-zs6uUWTgvo_Az+W+PKyA=rvxw@mail.gmail.com>
2019-12-03 21:15       ` Greg Kroah-Hartman
2019-12-03 21:18     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203.131844.1288568107728597971.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soheil@google.com \
    --cc=willemb@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).