From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()
Date: Tue, 3 Dec 2019 21:23:28 +0100 [thread overview]
Message-ID: <20191203202328.GA3183510@kroah.com> (raw)
In-Reply-To: <CANn89iLWjbVMw_UhR0wGC9iA3DoWYz7XtuTTgMmvq8x3zA2H4w@mail.gmail.com>
On Tue, Dec 03, 2019 at 11:30:29AM -0800, Eric Dumazet wrote:
> On Tue, Dec 3, 2019 at 11:22 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Dec 03, 2019 at 11:15:31AM -0800, Eric Dumazet wrote:
> > > On Tue, Dec 3, 2019 at 11:13 AM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Tue, Dec 03, 2019 at 08:05:52AM -0800, Eric Dumazet wrote:
> > > > > It appears linux-4.14 stable needs a backport of commit
> > > > > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
> > > > >
> > > > > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
> > > > > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
> > > >
> > > > So does that mean that 4.19.y should get 88f8598d0a30 ("tcp: exit if
> > > > nothing to retransmit on RTO timeout") as-is?
> > > >
> > >
> > > Yes indeed. All stable versions need it.
> >
> > So 4.4.y and 4.9.y as well?
>
> They should be fine, since they do not have yet :
>
> ba2ddb43f270e6492ccce4fc42fc32c611de8f68 tcp: Don't dequeue
> SYN/FIN-segments from write-queue
> f1dcc5ed4bea3f2d63b74ad86617ec12b1e5e9d4 tcp: Reset send_head when
> removing skb from write-queue
> 8e6521f6404e704fac313ab2479923be1f741f73 tcp: remove empty skb from
> write queue in error cases
>
> I would leave them untouched, to limit further problems :/
Great, thanks for letting me know.
greg k-h
next prev parent reply other threads:[~2019-12-03 20:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:05 [PATCH net] tcp: refactor tcp_retransmit_timer() Eric Dumazet
2019-12-03 16:08 ` Soheil Hassas Yeganeh
2019-12-03 19:13 ` Greg Kroah-Hartman
2019-12-03 19:15 ` Eric Dumazet
2019-12-03 19:22 ` Greg Kroah-Hartman
2019-12-03 19:30 ` Eric Dumazet
2019-12-03 20:23 ` Greg Kroah-Hartman [this message]
2019-12-03 19:53 ` David Miller
2019-12-03 20:23 ` Greg KH
[not found] ` <CANn89iKP7EZZRBtdcvFZVWP5-zs6uUWTgvo_Az+W+PKyA=rvxw@mail.gmail.com>
2019-12-03 21:15 ` Greg Kroah-Hartman
2019-12-03 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203202328.GA3183510@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=willemb@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).