From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Tariq Toukan <tariqt@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
oss-drivers@netronome.com
Subject: [PATCH RFC v7 net-next 3/1] netronome: use the new txqueue timeout argument
Date: Tue, 3 Dec 2019 02:32:14 -0500 [thread overview]
Message-ID: <20191203072757.429125-2-mst@redhat.com> (raw)
In-Reply-To: <20191203072757.429125-1-mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
untested
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 41a808b14d76..26f1fb19d0aa 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -1323,13 +1323,8 @@ nfp_net_tx_ring_reset(struct nfp_net_dp *dp, struct nfp_net_tx_ring *tx_ring)
static void nfp_net_tx_timeout(struct net_device *netdev, unsigned int txqueue)
{
struct nfp_net *nn = netdev_priv(netdev);
- int i;
- for (i = 0; i < nn->dp.netdev->real_num_tx_queues; i++) {
- if (!netif_tx_queue_stopped(netdev_get_tx_queue(netdev, i)))
- continue;
- nn_warn(nn, "TX timeout on ring: %d\n", i);
- }
+ nn_warn(nn, "TX timeout on ring: %d\n", txqueue);
nn_warn(nn, "TX watchdog timeout\n");
}
--
MST
next prev parent reply other threads:[~2019-12-03 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 7:12 [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler Michael S. Tsirkin
2019-12-03 7:32 ` [PATCH RFC v7 net-next 2/1] mlx4: use new txqueue timeout argument Michael S. Tsirkin
2019-12-03 7:32 ` Michael S. Tsirkin [this message]
2019-12-03 18:09 ` [PATCH RFC v7 net-next 3/1] netronome: use the " Jakub Kicinski
2019-12-03 18:07 ` [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler Jakub Kicinski
2019-12-03 19:24 ` Heiner Kallweit
2019-12-03 19:47 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203072757.429125-2-mst@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).