Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: David Miller <davem@davemloft.net>
To: martinvarghesenokia@gmail.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us,
	martin.varghese@nokia.com
Subject: Re: [PATCH net v2] net: Fixed updating of ethertype in skb_mpls_push()
Date: Wed, 04 Dec 2019 17:12:02 -0800 (PST)
Message-ID: <20191204.171202.946324250971280038.davem@davemloft.net> (raw)
In-Reply-To: <1575505642-5626-1-git-send-email-martinvarghesenokia@gmail.com>

From: Martin Varghese <martinvarghesenokia@gmail.com>
Date: Thu,  5 Dec 2019 05:57:22 +0530

> From: Martin Varghese <martin.varghese@nokia.com>
> 
> The skb_mpls_push was not updating ethertype of an ethernet packet if
> the packet was originally received from a non ARPHRD_ETHER device.
> 
> In the below OVS data path flow, since the device corresponding to
> port 7 is an l3 device (ARPHRD_NONE) the skb_mpls_push function does
> not update the ethertype of the packet even though the previous
> push_eth action had added an ethernet header to the packet.
> 
> recirc_id(0),in_port(7),eth_type(0x0800),ipv4(tos=0/0xfc,ttl=64,frag=no),
> actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
> push_mpls(label=13,tc=0,ttl=64,bos=1,eth_type=0x8847),4
> 
> Fixes: 8822e270d697 ("net: core: move push MPLS functionality from OvS to core helper")
> Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
> ---
> Changes in v2:
>     Changed the subject line of patch.

Applied and queued up for -stable, thanks.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  0:27 Martin Varghese
2019-12-05  1:12 ` David Miller [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204.171202.946324250971280038.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=martin.varghese@nokia.com \
    --cc=martinvarghesenokia@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git