Re: net: dsa: mv88e6xxx: error parsing ethernet node from dts

From: Andrew Lunn <andrew@lunn.ch>
To: "Jürgen Lambrecht" <j.lambrecht@televic.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	rasmus.villemoes@prevas.dk,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	vivien.didelot@gmail.com
Subject: Re: net: dsa: mv88e6xxx: error parsing ethernet node from dts
Date: Wed, 4 Dec 2019 18:13:36 +0100	[thread overview]
Message-ID: <20191204171336.GF21904@lunn.ch> (raw)
In-Reply-To: <ccf9c80e-83e5-d207-8d09-1819cfb1cf35@televic.com>

On Wed, Dec 04, 2019 at 05:20:04PM +0100, Jürgen Lambrecht wrote:
> On 12/4/19 4:38 PM, Andrew Lunn wrote:
> >> Here parts of dmesg (no error reported):
> >>
> >> [    1.992342] libphy: Fixed MDIO Bus: probed
> >> [    2.009532] pps pps0: new PPS source ptp0
> >> [    2.014387] libphy: fec_enet_mii_bus: probed
> >> [    2.017159] mv88e6085 2188000.ethernet-1:00: switch 0x710 detected: Marvell 88E6071, revision 5
> >> [    2.125616] libphy: mv88e6xxx SMI: probed
> >> [    2.134450] fec 2188000.ethernet eth0: registered PHC device 0
> >> ...
> >> [   11.366359] Generic PHY fixed-0:00: attached PHY driver [Generic PHY] (mii_bus:phy_addr=fixed-0:00, irq=POLL)
> >> [   11.366722] fec 2188000.ethernet eth0: Link is Up - 100Mbps/Full - flow control off
> >>
> >> When I enable debugging in the source code, I see that mv88e6xxx_probe() fails, because *'of_find_net_device_by_node(ethernet);'* fails. But why?,
> > That always happens the first time. There is a chicken/egg
> > problem. The MDIO bus is registered by the FEC driver, the switch is
> > probed, and the DSA core looks for the ethernet interface. But the FEC
> > driver has not yet registered the interface, it is still busy
> > registering the MDIO bus. So you get an EPRODE_DEFFER from the switch
> > probe. The FEC then completes its probe, registering the
> > interface. Sometime later Linux retries the switch probe, and this
> > time it works.
> >
> > What you are seeing here is the first attempt. There should be a
> > second go later in the log.
> >
> >        Andrew
> 

> Indeed, but that also fails because this second time, reading the
> switch ID (macreg 3 at addr 8) fails, it returns 0x0000!??

So this is the real problem.

Try removing the reset GPIO line from DT. If there is an EEPROM, and
the EEPROM contains a lot of instructions, we have seen it take a long
time to reset, load the EEPROM, and then start responding on the MDIO
bus. If you take away the GPIO, it will only do a software reset,
which is much faster. Even if you don't have an EEPROM, it is worth a
try.

But returning 0x0000 is odd. Normally, if an MDIO device does not
respond, you read 0xffff, because of the pull up resistor on the bus.

The fact you find it once means it is something like this, some minor
configuration problem, power management, etc.

	 Andrew