From: Andrew Lunn <andrew@lunn.ch>
To: "Jürgen Lambrecht" <j.lambrecht@televic.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
rasmus.villemoes@prevas.dk,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
vivien.didelot@gmail.com,
"Antoine Ténart" <antoine.tenart@bootlin.com>
Subject: Re: net: dsa: mv88e6xxx: error parsing ethernet node from dts
Date: Mon, 9 Dec 2019 14:43:36 +0100 [thread overview]
Message-ID: <20191209134336.GC9099@lunn.ch> (raw)
In-Reply-To: <5851b137-2a3f-f8b3-cd0a-6efc2b7df67d@televic.com>
> A strange thing to me however is why - in my dts and in
> vf610-zii-ssmb-spu3.dts - there is 2 times a 'fixed-link'
> declaration? Moreover, when I omit the first declaration, the kernel
> crashes (oops).
The FEC driver expect there to be a PHY connected to the MAC, and the
PHY should indicate what speed the link is running at. However, the
FEC is directly connected to the switch, there is no PHY involved. To
keep the FEC happy, and to tell it what speed to use, a fixed-link PHY
is used. It uses the same API as a real PHY, and indicates the link is
using the speed as defined in DT. So the FEC runs at 100Mbps.
The DSA driver defaults to configuring the CPU port at its maximum
speed. For this chip, that is 1Gbps. However, the Vybrid FEC can only
support 100Mbps. So we need to force the CPU port to the slower
speed. Hence the fixed link in the CPU node.
Andrew
next prev parent reply other threads:[~2019-12-09 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 14:18 net: dsa: mv88e6xxx: error parsing ethernet node from dts Jürgen Lambrecht
2019-12-04 15:38 ` Andrew Lunn
2019-12-04 16:20 ` Jürgen Lambrecht
2019-12-04 17:13 ` Andrew Lunn
2019-12-09 7:57 ` Jürgen Lambrecht
2019-12-09 13:43 ` Andrew Lunn [this message]
2019-12-24 10:28 ` Jürgen Lambrecht
2019-12-24 11:19 ` Andrew Lunn
2019-12-24 13:57 ` Jürgen Lambrecht
2020-01-06 7:11 ` Jürgen Lambrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209134336.GC9099@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=j.lambrecht@televic.com \
--cc=netdev@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).