* [PATCH] net-sysfs: Call dev_hold always in netdev_queue_add_kobject
@ 2019-12-05 13:57 jouni.hogander
2019-12-07 4:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: jouni.hogander @ 2019-12-05 13:57 UTC (permalink / raw)
To: netdev; +Cc: Jouni Hogander, Tetsuo Handa, David Miller, Lukas Bulwahn
From: Jouni Hogander <jouni.hogander@unikie.com>
Dev_hold has to be called always in netdev_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.
Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: Hulk Robot <hulkci@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
net/core/net-sysfs.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index ae3bcb1540ec..5c4624298996 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1459,14 +1459,17 @@ static int netdev_queue_add_kobject(struct net_device *dev, int index)
struct kobject *kobj = &queue->kobj;
int error = 0;
+ /* Kobject_put later will trigger netdev_queue_release call
+ * which decreases dev refcount: Take that reference here
+ */
+ dev_hold(queue->dev);
+
kobj->kset = dev->queues_kset;
error = kobject_init_and_add(kobj, &netdev_queue_ktype, NULL,
"tx-%u", index);
if (error)
goto err;
- dev_hold(queue->dev);
-
#ifdef CONFIG_BQL
error = sysfs_create_group(kobj, &dql_group);
if (error)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net-sysfs: Call dev_hold always in netdev_queue_add_kobject
2019-12-05 13:57 [PATCH] net-sysfs: Call dev_hold always in netdev_queue_add_kobject jouni.hogander
@ 2019-12-07 4:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-07 4:39 UTC (permalink / raw)
To: jouni.hogander; +Cc: netdev, penguin-kernel, lukas.bulwahn
From: jouni.hogander@unikie.com
Date: Thu, 5 Dec 2019 15:57:07 +0200
> From: Jouni Hogander <jouni.hogander@unikie.com>
>
> Dev_hold has to be called always in netdev_queue_add_kobject.
> Otherwise usage count drops below 0 in case of failure in
> kobject_init_and_add.
>
> Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> Reported-by: Hulk Robot <hulkci@huawei.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-07 4:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 13:57 [PATCH] net-sysfs: Call dev_hold always in netdev_queue_add_kobject jouni.hogander
2019-12-07 4:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).