* [PATCH] phy: mdio-thunder: add missed pci_release_regions in remove
@ 2019-12-06 7:54 Chuhong Yuan
2019-12-06 20:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-12-06 7:54 UTC (permalink / raw)
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S . Miller,
netdev, linux-kernel, Chuhong Yuan
The driver forgets to call pci_release_regions() in remove like that
in probe failure.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/net/phy/mdio-thunder.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/mdio-thunder.c b/drivers/net/phy/mdio-thunder.c
index b6128ae7f14f..2a97938d1972 100644
--- a/drivers/net/phy/mdio-thunder.c
+++ b/drivers/net/phy/mdio-thunder.c
@@ -129,6 +129,7 @@ static void thunder_mdiobus_pci_remove(struct pci_dev *pdev)
mdiobus_free(bus->mii_bus);
oct_mdio_writeq(0, bus->register_base + SMI_EN);
}
+ pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);
}
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: mdio-thunder: add missed pci_release_regions in remove
2019-12-06 7:54 [PATCH] phy: mdio-thunder: add missed pci_release_regions in remove Chuhong Yuan
@ 2019-12-06 20:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-06 20:05 UTC (permalink / raw)
To: hslester96; +Cc: andrew, f.fainelli, hkallweit1, netdev, linux-kernel
From: Chuhong Yuan <hslester96@gmail.com>
Date: Fri, 6 Dec 2019 15:54:46 +0800
> The driver forgets to call pci_release_regions() in remove like that
> in probe failure.
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-06 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 7:54 [PATCH] phy: mdio-thunder: add missed pci_release_regions in remove Chuhong Yuan
2019-12-06 20:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).