* [PATCH v2 -next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu().
@ 2019-12-09 13:08 Mao Wenan
2019-12-09 22:27 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Mao Wenan @ 2019-12-09 13:08 UTC (permalink / raw)
To: davem, gregkh, alexios.zavras, oneukum, tglx
Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan, Hulk Robot
Convert cpu_to_le16(le16_to_cpu(frame->datalen) + len) to
use le16_add_cpu(), which is more concise and does the same thing.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v2: change log as julia suggest.
drivers/nfc/port100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c
index 604dba4..8e4d355 100644
--- a/drivers/nfc/port100.c
+++ b/drivers/nfc/port100.c
@@ -565,7 +565,7 @@ static void port100_tx_update_payload_len(void *_frame, int len)
{
struct port100_frame *frame = _frame;
- frame->datalen = cpu_to_le16(le16_to_cpu(frame->datalen) + len);
+ le16_add_cpu(&frame->datalen, len);
}
static bool port100_rx_frame_is_valid(void *_frame)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 -next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu().
2019-12-09 13:08 [PATCH v2 -next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu() Mao Wenan
@ 2019-12-09 22:27 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2019-12-09 22:27 UTC (permalink / raw)
To: maowenan
Cc: gregkh, alexios.zavras, oneukum, tglx, netdev, linux-kernel,
kernel-janitors, hulkci
From: Mao Wenan <maowenan@huawei.com>
Date: Mon, 9 Dec 2019 21:08:45 +0800
> Convert cpu_to_le16(le16_to_cpu(frame->datalen) + len) to
> use le16_add_cpu(), which is more concise and does the same thing.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 -next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu().
2019-12-04 6:37 [PATCH " Mao Wenan
@ 2019-12-04 7:18 ` Mao Wenan
0 siblings, 0 replies; 3+ messages in thread
From: Mao Wenan @ 2019-12-04 7:18 UTC (permalink / raw)
To: davem, gregkh, alexios.zavras, oneukum, tglx, julia.lawall
Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan, Hulk Robot
Convert cpu_to_le16(le16_to_cpu(frame->datalen) + len) to
use le16_add_cpu(), which is more concise and does the same thing.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v2: change log as julia suggest.
drivers/nfc/port100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c
index 604dba4..8e4d355 100644
--- a/drivers/nfc/port100.c
+++ b/drivers/nfc/port100.c
@@ -565,7 +565,7 @@ static void port100_tx_update_payload_len(void *_frame, int len)
{
struct port100_frame *frame = _frame;
- frame->datalen = cpu_to_le16(le16_to_cpu(frame->datalen) + len);
+ le16_add_cpu(&frame->datalen, len);
}
static bool port100_rx_frame_is_valid(void *_frame)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-09 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 13:08 [PATCH v2 -next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu() Mao Wenan
2019-12-09 22:27 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-12-04 6:37 [PATCH " Mao Wenan
2019-12-04 7:18 ` [PATCH v2 " Mao Wenan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).