* [PATCH net-next 1/4] net: sfp: use a definition for the fault recovery attempts
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
@ 2019-12-09 14:15 ` Russell King
2019-12-09 17:43 ` Andrew Lunn
2019-12-09 14:16 ` [PATCH net-next 2/4] net: sfp: rename sm_retries Russell King
` (4 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Russell King @ 2019-12-09 14:15 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/sfp.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index bfe268028154..b1c564b79e3e 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -172,6 +172,14 @@ static const enum gpiod_flags gpio_flags[] = {
#define T_RESET_US 10
#define T_FAULT_RECOVER msecs_to_jiffies(1000)
+/* N_FAULT_INIT is the number of recovery attempts at module initialisation
+ * time. If the TX_FAULT signal is not deasserted after this number of
+ * attempts at clearing it, we decide that the module is faulty.
+ * N_FAULT is the same but after the module has initialised.
+ */
+#define N_FAULT_INIT 5
+#define N_FAULT 5
+
/* SFP module presence detection is poor: the three MOD DEF signals are
* the same length on the PCB, which means it's possible for MOD DEF 0 to
* connect before the I2C bus on MOD DEF 1/2.
@@ -1885,7 +1893,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
sfp_module_tx_enable(sfp);
/* Initialise the fault clearance retries */
- sfp->sm_retries = 5;
+ sfp->sm_retries = N_FAULT_INIT;
/* We need to check the TX_FAULT state, which is not defined
* while TX_DISABLE is asserted. The earliest we want to do
@@ -1925,7 +1933,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
* or t_start_up, so assume there is a fault.
*/
sfp_sm_fault(sfp, SFP_S_INIT_TX_FAULT,
- sfp->sm_retries == 5);
+ sfp->sm_retries == N_FAULT_INIT);
} else if (event == SFP_E_TIMEOUT || event == SFP_E_TX_CLEAR) {
init_done: /* TX_FAULT deasserted or we timed out with TX_FAULT
* clear. Probe for the PHY and check the LOS state.
@@ -1938,7 +1946,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
sfp_sm_link_check_los(sfp);
/* Reset the fault retry count */
- sfp->sm_retries = 5;
+ sfp->sm_retries = N_FAULT;
}
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next 2/4] net: sfp: rename sm_retries
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
2019-12-09 14:15 ` [PATCH net-next 1/4] net: sfp: use a definition for the fault recovery attempts Russell King
@ 2019-12-09 14:16 ` Russell King
2019-12-09 17:44 ` Andrew Lunn
2019-12-09 14:16 ` [PATCH net-next 3/4] net: sfp: error handling for phy probe Russell King
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Russell King @ 2019-12-09 14:16 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev
Rename sm_retries as sm_fault_retries, as this is what this member is
tracking.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/sfp.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index b1c564b79e3e..a67f089f2106 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -234,7 +234,7 @@ struct sfp {
unsigned char sm_mod_tries;
unsigned char sm_dev_state;
unsigned short sm_state;
- unsigned int sm_retries;
+ unsigned char sm_fault_retries;
struct sfp_eeprom_id id;
unsigned int module_power_mW;
@@ -1490,7 +1490,7 @@ static bool sfp_los_event_inactive(struct sfp *sfp, unsigned int event)
static void sfp_sm_fault(struct sfp *sfp, unsigned int next_state, bool warn)
{
- if (sfp->sm_retries && !--sfp->sm_retries) {
+ if (sfp->sm_fault_retries && !--sfp->sm_fault_retries) {
dev_err(sfp->dev,
"module persistently indicates fault, disabling\n");
sfp_sm_next(sfp, SFP_S_TX_DISABLE, 0);
@@ -1893,7 +1893,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
sfp_module_tx_enable(sfp);
/* Initialise the fault clearance retries */
- sfp->sm_retries = N_FAULT_INIT;
+ sfp->sm_fault_retries = N_FAULT_INIT;
/* We need to check the TX_FAULT state, which is not defined
* while TX_DISABLE is asserted. The earliest we want to do
@@ -1933,7 +1933,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
* or t_start_up, so assume there is a fault.
*/
sfp_sm_fault(sfp, SFP_S_INIT_TX_FAULT,
- sfp->sm_retries == N_FAULT_INIT);
+ sfp->sm_fault_retries == N_FAULT_INIT);
} else if (event == SFP_E_TIMEOUT || event == SFP_E_TX_CLEAR) {
init_done: /* TX_FAULT deasserted or we timed out with TX_FAULT
* clear. Probe for the PHY and check the LOS state.
@@ -1946,7 +1946,7 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
sfp_sm_link_check_los(sfp);
/* Reset the fault retry count */
- sfp->sm_retries = N_FAULT;
+ sfp->sm_fault_retries = N_FAULT;
}
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next 3/4] net: sfp: error handling for phy probe
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
2019-12-09 14:15 ` [PATCH net-next 1/4] net: sfp: use a definition for the fault recovery attempts Russell King
2019-12-09 14:16 ` [PATCH net-next 2/4] net: sfp: rename sm_retries Russell King
@ 2019-12-09 14:16 ` Russell King
2019-12-09 17:45 ` Andrew Lunn
2019-12-09 14:16 ` [PATCH net-next 4/4] net: sfp: re-attempt probing for phy Russell King
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Russell King @ 2019-12-09 14:16 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/sfp.c | 26 +++++++++++++++++---------
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index a67f089f2106..76fa95e54542 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1410,7 +1410,7 @@ static void sfp_sm_phy_detach(struct sfp *sfp)
sfp->mod_phy = NULL;
}
-static void sfp_sm_probe_phy(struct sfp *sfp, bool is_c45)
+static int sfp_sm_probe_phy(struct sfp *sfp, bool is_c45)
{
struct phy_device *phy;
int err;
@@ -1418,18 +1418,18 @@ static void sfp_sm_probe_phy(struct sfp *sfp, bool is_c45)
phy = get_phy_device(sfp->i2c_mii, SFP_PHY_ADDR, is_c45);
if (phy == ERR_PTR(-ENODEV)) {
dev_info(sfp->dev, "no PHY detected\n");
- return;
+ return 0;
}
if (IS_ERR(phy)) {
dev_err(sfp->dev, "mdiobus scan returned %ld\n", PTR_ERR(phy));
- return;
+ return PTR_ERR(phy);
}
err = phy_device_register(phy);
if (err) {
phy_device_free(phy);
dev_err(sfp->dev, "phy_device_register failed: %d\n", err);
- return;
+ return err;
}
err = sfp_add_phy(sfp->sfp_bus, phy);
@@ -1437,10 +1437,12 @@ static void sfp_sm_probe_phy(struct sfp *sfp, bool is_c45)
phy_device_remove(phy);
phy_device_free(phy);
dev_err(sfp->dev, "sfp_add_phy failed: %d\n", err);
- return;
+ return err;
}
sfp->mod_phy = phy;
+
+ return 0;
}
static void sfp_sm_link_up(struct sfp *sfp)
@@ -1513,21 +1515,24 @@ static void sfp_sm_fault(struct sfp *sfp, unsigned int next_state, bool warn)
* Clause 45 copper SFP+ modules (10G) appear to switch their interface
* mode according to the negotiated line speed.
*/
-static void sfp_sm_probe_for_phy(struct sfp *sfp)
+static int sfp_sm_probe_for_phy(struct sfp *sfp)
{
+ int err = 0;
+
switch (sfp->id.base.extended_cc) {
case SFF8024_ECC_10GBASE_T_SFI:
case SFF8024_ECC_10GBASE_T_SR:
case SFF8024_ECC_5GBASE_T:
case SFF8024_ECC_2_5GBASE_T:
- sfp_sm_probe_phy(sfp, true);
+ err = sfp_sm_probe_phy(sfp, true);
break;
default:
if (sfp->id.base.e1000_base_t)
- sfp_sm_probe_phy(sfp, false);
+ err = sfp_sm_probe_phy(sfp, false);
break;
}
+ return err;
}
static int sfp_module_parse_power(struct sfp *sfp)
@@ -1938,7 +1943,10 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
init_done: /* TX_FAULT deasserted or we timed out with TX_FAULT
* clear. Probe for the PHY and check the LOS state.
*/
- sfp_sm_probe_for_phy(sfp);
+ if (sfp_sm_probe_for_phy(sfp)) {
+ sfp_sm_next(sfp, SFP_S_FAIL, 0);
+ break;
+ }
if (sfp_module_start(sfp->sfp_bus)) {
sfp_sm_next(sfp, SFP_S_FAIL, 0);
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next 4/4] net: sfp: re-attempt probing for phy
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
` (2 preceding siblings ...)
2019-12-09 14:16 ` [PATCH net-next 3/4] net: sfp: error handling for phy probe Russell King
@ 2019-12-09 14:16 ` Russell King
2019-12-09 17:47 ` Andrew Lunn
2019-12-09 22:34 ` [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules David Miller
2019-12-11 20:46 ` David Miller
5 siblings, 1 reply; 14+ messages in thread
From: Russell King @ 2019-12-09 14:16 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev
Some 1000BASE-T PHY modules take a while for the PHY to wake up.
Retry the probe a number of times before deciding that the module has
no PHY.
Tested with:
Sourcephotonics SPGBTXCNFC - PHY takes less than 50ms to respond.
Champion One 1000SFPT - PHY takes about 200ms to respond.
Mikrotik S-RJ01 - no PHY
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/sfp.c | 59 ++++++++++++++++++++++++++++++-------------
1 file changed, 42 insertions(+), 17 deletions(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 76fa95e54542..e54aef921038 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -62,6 +62,7 @@ enum {
SFP_S_FAIL,
SFP_S_WAIT,
SFP_S_INIT,
+ SFP_S_INIT_PHY,
SFP_S_INIT_TX_FAULT,
SFP_S_WAIT_LOS,
SFP_S_LINK_UP,
@@ -126,6 +127,7 @@ static const char * const sm_state_strings[] = {
[SFP_S_FAIL] = "fail",
[SFP_S_WAIT] = "wait",
[SFP_S_INIT] = "init",
+ [SFP_S_INIT_PHY] = "init_phy",
[SFP_S_INIT_TX_FAULT] = "init_tx_fault",
[SFP_S_WAIT_LOS] = "wait_los",
[SFP_S_LINK_UP] = "link_up",
@@ -180,6 +182,12 @@ static const enum gpiod_flags gpio_flags[] = {
#define N_FAULT_INIT 5
#define N_FAULT 5
+/* T_PHY_RETRY is the time interval between attempts to probe the PHY.
+ * R_PHY_RETRY is the number of attempts.
+ */
+#define T_PHY_RETRY msecs_to_jiffies(50)
+#define R_PHY_RETRY 12
+
/* SFP module presence detection is poor: the three MOD DEF signals are
* the same length on the PCB, which means it's possible for MOD DEF 0 to
* connect before the I2C bus on MOD DEF 1/2.
@@ -235,6 +243,7 @@ struct sfp {
unsigned char sm_dev_state;
unsigned short sm_state;
unsigned char sm_fault_retries;
+ unsigned char sm_phy_retries;
struct sfp_eeprom_id id;
unsigned int module_power_mW;
@@ -1416,10 +1425,8 @@ static int sfp_sm_probe_phy(struct sfp *sfp, bool is_c45)
int err;
phy = get_phy_device(sfp->i2c_mii, SFP_PHY_ADDR, is_c45);
- if (phy == ERR_PTR(-ENODEV)) {
- dev_info(sfp->dev, "no PHY detected\n");
- return 0;
- }
+ if (phy == ERR_PTR(-ENODEV))
+ return PTR_ERR(phy);
if (IS_ERR(phy)) {
dev_err(sfp->dev, "mdiobus scan returned %ld\n", PTR_ERR(phy));
return PTR_ERR(phy);
@@ -1867,6 +1874,7 @@ static void sfp_sm_module(struct sfp *sfp, unsigned int event)
static void sfp_sm_main(struct sfp *sfp, unsigned int event)
{
unsigned long timeout;
+ int ret;
/* Some events are global */
if (sfp->sm_state != SFP_S_DOWN &&
@@ -1940,22 +1948,39 @@ static void sfp_sm_main(struct sfp *sfp, unsigned int event)
sfp_sm_fault(sfp, SFP_S_INIT_TX_FAULT,
sfp->sm_fault_retries == N_FAULT_INIT);
} else if (event == SFP_E_TIMEOUT || event == SFP_E_TX_CLEAR) {
- init_done: /* TX_FAULT deasserted or we timed out with TX_FAULT
- * clear. Probe for the PHY and check the LOS state.
- */
- if (sfp_sm_probe_for_phy(sfp)) {
- sfp_sm_next(sfp, SFP_S_FAIL, 0);
- break;
- }
- if (sfp_module_start(sfp->sfp_bus)) {
- sfp_sm_next(sfp, SFP_S_FAIL, 0);
+ init_done:
+ sfp->sm_phy_retries = R_PHY_RETRY;
+ goto phy_probe;
+ }
+ break;
+
+ case SFP_S_INIT_PHY:
+ if (event != SFP_E_TIMEOUT)
+ break;
+ phy_probe:
+ /* TX_FAULT deasserted or we timed out with TX_FAULT
+ * clear. Probe for the PHY and check the LOS state.
+ */
+ ret = sfp_sm_probe_for_phy(sfp);
+ if (ret == -ENODEV) {
+ if (--sfp->sm_phy_retries) {
+ sfp_sm_next(sfp, SFP_S_INIT_PHY, T_PHY_RETRY);
break;
+ } else {
+ dev_info(sfp->dev, "no PHY detected\n");
}
- sfp_sm_link_check_los(sfp);
-
- /* Reset the fault retry count */
- sfp->sm_fault_retries = N_FAULT;
+ } else if (ret) {
+ sfp_sm_next(sfp, SFP_S_FAIL, 0);
+ break;
}
+ if (sfp_module_start(sfp->sfp_bus)) {
+ sfp_sm_next(sfp, SFP_S_FAIL, 0);
+ break;
+ }
+ sfp_sm_link_check_los(sfp);
+
+ /* Reset the fault retry count */
+ sfp->sm_fault_retries = N_FAULT;
break;
case SFP_S_INIT_TX_FAULT:
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 4/4] net: sfp: re-attempt probing for phy
2019-12-09 14:16 ` [PATCH net-next 4/4] net: sfp: re-attempt probing for phy Russell King
@ 2019-12-09 17:47 ` Andrew Lunn
0 siblings, 0 replies; 14+ messages in thread
From: Andrew Lunn @ 2019-12-09 17:47 UTC (permalink / raw)
To: Russell King; +Cc: Florian Fainelli, Heiner Kallweit, David S. Miller, netdev
On Mon, Dec 09, 2019 at 02:16:11PM +0000, Russell King wrote:
> Some 1000BASE-T PHY modules take a while for the PHY to wake up.
> Retry the probe a number of times before deciding that the module has
> no PHY.
>
> Tested with:
> Sourcephotonics SPGBTXCNFC - PHY takes less than 50ms to respond.
> Champion One 1000SFPT - PHY takes about 200ms to respond.
> Mikrotik S-RJ01 - no PHY
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
` (3 preceding siblings ...)
2019-12-09 14:16 ` [PATCH net-next 4/4] net: sfp: re-attempt probing for phy Russell King
@ 2019-12-09 22:34 ` David Miller
2019-12-09 22:35 ` David Miller
2019-12-09 22:37 ` Russell King - ARM Linux admin
2019-12-11 20:46 ` David Miller
5 siblings, 2 replies; 14+ messages in thread
From: David Miller @ 2019-12-09 22:34 UTC (permalink / raw)
To: linux; +Cc: andrew, f.fainelli, hkallweit1, netdev
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Mon, 9 Dec 2019 14:15:25 +0000
> This series, following on from the previous adding SFP+ copper support,
> adds support for a range of Copper SFP modules, made by a variety of
> companies, all of which have a Marvell 88E1111 PHY on them, but take
> far longer than the Marvell spec'd 15ms to start communicating on the
> I2C bus.
>
> Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
> routed through a MAX1971 switching regulator and reset IC which adds a
> 175ms delay to releasing the 88E1111 reset.
>
> It is not known whether other modules use a similar setup, but there
> are a range of modules that are slow for the Marvell PHY to appear.
>
> This patch series adds support for these modules by repeatedly trying
> to probe the PHY for up to 600ms.
Patch #3 gets full rejects when I try to apply this series.
Please respin, adding Andrew's ACKs.
Thank you.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules
2019-12-09 22:34 ` [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules David Miller
@ 2019-12-09 22:35 ` David Miller
2019-12-09 22:38 ` Russell King - ARM Linux admin
2019-12-09 22:37 ` Russell King - ARM Linux admin
1 sibling, 1 reply; 14+ messages in thread
From: David Miller @ 2019-12-09 22:35 UTC (permalink / raw)
To: linux; +Cc: andrew, f.fainelli, hkallweit1, netdev
From: David Miller <davem@davemloft.net>
Date: Mon, 09 Dec 2019 14:34:49 -0800 (PST)
> From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> Date: Mon, 9 Dec 2019 14:15:25 +0000
>
>> This series, following on from the previous adding SFP+ copper support,
>> adds support for a range of Copper SFP modules, made by a variety of
>> companies, all of which have a Marvell 88E1111 PHY on them, but take
>> far longer than the Marvell spec'd 15ms to start communicating on the
>> I2C bus.
>>
>> Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
>> routed through a MAX1971 switching regulator and reset IC which adds a
>> 175ms delay to releasing the 88E1111 reset.
>>
>> It is not known whether other modules use a similar setup, but there
>> are a range of modules that are slow for the Marvell PHY to appear.
>>
>> This patch series adds support for these modules by repeatedly trying
>> to probe the PHY for up to 600ms.
>
> Patch #3 gets full rejects when I try to apply this series.
>
> Please respin, adding Andrew's ACKs.
Oh nevermind, I see this depends upon a series that's now in v2 and
thus appears later int he queue.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules
2019-12-09 22:35 ` David Miller
@ 2019-12-09 22:38 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-09 22:38 UTC (permalink / raw)
To: David Miller; +Cc: andrew, f.fainelli, hkallweit1, netdev
On Mon, Dec 09, 2019 at 02:35:25PM -0800, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 09 Dec 2019 14:34:49 -0800 (PST)
>
> > From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> > Date: Mon, 9 Dec 2019 14:15:25 +0000
> >
> >> This series, following on from the previous adding SFP+ copper support,
> >> adds support for a range of Copper SFP modules, made by a variety of
> >> companies, all of which have a Marvell 88E1111 PHY on them, but take
> >> far longer than the Marvell spec'd 15ms to start communicating on the
> >> I2C bus.
> >>
> >> Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
> >> routed through a MAX1971 switching regulator and reset IC which adds a
> >> 175ms delay to releasing the 88E1111 reset.
> >>
> >> It is not known whether other modules use a similar setup, but there
> >> are a range of modules that are slow for the Marvell PHY to appear.
> >>
> >> This patch series adds support for these modules by repeatedly trying
> >> to probe the PHY for up to 600ms.
> >
> > Patch #3 gets full rejects when I try to apply this series.
> >
> > Please respin, adding Andrew's ACKs.
>
> Oh nevermind, I see this depends upon a series that's now in v2 and
> thus appears later int he queue.
Yep. I'm hoping some comments will be forthcoming on that series soon.
Thanks for looking anyway.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules
2019-12-09 22:34 ` [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules David Miller
2019-12-09 22:35 ` David Miller
@ 2019-12-09 22:37 ` Russell King - ARM Linux admin
1 sibling, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-09 22:37 UTC (permalink / raw)
To: David Miller; +Cc: andrew, f.fainelli, hkallweit1, netdev
On Mon, Dec 09, 2019 at 02:34:49PM -0800, David Miller wrote:
> From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> Date: Mon, 9 Dec 2019 14:15:25 +0000
>
> > This series, following on from the previous adding SFP+ copper support,
> > adds support for a range of Copper SFP modules, made by a variety of
> > companies, all of which have a Marvell 88E1111 PHY on them, but take
> > far longer than the Marvell spec'd 15ms to start communicating on the
> > I2C bus.
> >
> > Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
> > routed through a MAX1971 switching regulator and reset IC which adds a
> > 175ms delay to releasing the 88E1111 reset.
> >
> > It is not known whether other modules use a similar setup, but there
> > are a range of modules that are slow for the Marvell PHY to appear.
> >
> > This patch series adds support for these modules by repeatedly trying
> > to probe the PHY for up to 600ms.
>
> Patch #3 gets full rejects when I try to apply this series.
>
> Please respin, adding Andrew's ACKs.
As mentioned in the very first sentence, it depends on the previously
submitted series, which hasn't yet been reviewed.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules
2019-12-09 14:15 [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Russell King - ARM Linux admin
` (4 preceding siblings ...)
2019-12-09 22:34 ` [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules David Miller
@ 2019-12-11 20:46 ` David Miller
5 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2019-12-11 20:46 UTC (permalink / raw)
To: linux; +Cc: andrew, f.fainelli, hkallweit1, netdev
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Mon, 9 Dec 2019 14:15:25 +0000
> This series, following on from the previous adding SFP+ copper support,
> adds support for a range of Copper SFP modules, made by a variety of
> companies, all of which have a Marvell 88E1111 PHY on them, but take
> far longer than the Marvell spec'd 15ms to start communicating on the
> I2C bus.
>
> Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
> routed through a MAX1971 switching regulator and reset IC which adds a
> 175ms delay to releasing the 88E1111 reset.
>
> It is not known whether other modules use a similar setup, but there
> are a range of modules that are slow for the Marvell PHY to appear.
>
> This patch series adds support for these modules by repeatedly trying
> to probe the PHY for up to 600ms.
Series applied.
^ permalink raw reply [flat|nested] 14+ messages in thread