From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Milind Parab <mparab@cadence.com>
Cc: <nicolas.nerre@microchip.com>, <andrew@lunn.ch>,
<antoine.tenart@bootlin.com>, <f.fainelli@gmail.com>,
<rmk+kernel@armlinux.org.uk>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <hkallweit1@gmail.com>,
<linux-kernel@vger.kernel.org>, <dkangude@cadence.com>,
<a.fatoum@pengutronix.de>, <brad.mouring@ni.com>,
<pthombar@cadence.com>
Subject: Re: [PATCH v2 1/3] net: macb: fix for fixed-link mode
Date: Sat, 14 Dec 2019 20:33:37 -0800 [thread overview]
Message-ID: <20191214203337.687ebd6b@cakuba.netronome.com> (raw)
In-Reply-To: <1576230061-11239-1-git-send-email-mparab@cadence.com>
On Fri, 13 Dec 2019 09:41:01 +0000, Milind Parab wrote:
> This patch fix the issue with fixed link. With fixed-link
> device opening fails due to macb_phylink_connect not
> handling fixed-link mode, in which case no MAC-PHY connection
> is needed and phylink_connect return success (0), however
> in current driver attempt is made to search and connect to
> PHY even for fixed-link.
>
> Signed-off-by: Milind Parab <mparab@cadence.com>
We'll wait to give a chance for Russell, Andrew and others to review,
but this patch looks like a fix and the other ones look like features.
You should post the fix separately so it's included in Linus'es tree
ASAP (mark the patch with [PATCH net]), and the rest of the patches can
wait for the next merge window (mark [PATCH net-next]). Fixes should
also have an appropriate Fixes tag pointing at the first commit where
the bug was present.
next prev parent reply other threads:[~2019-12-15 4:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 9:40 [PATCH v2 0/3] net: macb: fix for fixed link, support for c45 mdio and 10G Milind Parab
2019-12-13 9:41 ` [PATCH v2 1/3] net: macb: fix for fixed-link mode Milind Parab
2019-12-15 4:33 ` Jakub Kicinski [this message]
2019-12-13 9:41 ` [PATCH v2 2/3] net: macb: add support for C45 MDIO read/write Milind Parab
2019-12-15 14:56 ` Andrew Lunn
2019-12-13 9:42 ` [PATCH v2 3/3] net: macb: add support for high speed interface Milind Parab
2019-12-15 15:12 ` Russell King - ARM Linux admin
2019-12-15 15:20 ` Russell King - ARM Linux admin
2019-12-16 12:49 ` Milind Parab
2019-12-16 13:09 ` Russell King - ARM Linux admin
2019-12-16 14:30 ` Russell King - ARM Linux admin
2019-12-20 9:05 ` Milind Parab
2019-12-21 11:08 ` Milind Parab
2020-01-08 10:32 ` Nicolas.Ferre
2019-12-15 9:49 ` [PATCH v2 0/3] net: macb: fix for fixed link, support for c45 mdio and 10G Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191214203337.687ebd6b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=a.fatoum@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=brad.mouring@ni.com \
--cc=davem@davemloft.net \
--cc=dkangude@cadence.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.nerre@microchip.com \
--cc=pthombar@cadence.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).