From: Milind Parab <mparab@cadence.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "nicolas.nerre@microchip.com" <nicolas.nerre@microchip.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dhananjay Vilasrao Kangude <dkangude@cadence.com>,
"a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
"brad.mouring@ni.com" <brad.mouring@ni.com>,
Parshuram Raju Thombare <pthombar@cadence.com>
Subject: RE: [PATCH v2 3/3] net: macb: add support for high speed interface
Date: Fri, 20 Dec 2019 09:05:35 +0000 [thread overview]
Message-ID: <BY5PR07MB65143BFFE9D08FBA2BD94669D32D0@BY5PR07MB6514.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20191216130908.GI25745@shell.armlinux.org.uk>
>>
>> Additional 3rd party I2C IP required (not part of GEM) for module
>> interrogation (MDIO to I2C handled by SW
>> +--------------+ +-----------+
>> | | | | | SFP+ |
>> | GEM MAC/DMA | <---> | SerDes | <---- SFI-----> | Optical |
>> | USX PCS| | | (PMA) | | Module |
>> +--------------+ +-----------+
>> ^
>> +--------+ |
>> | I2C | |
>> | Master | <-------------------------------------|
>> +--------+
>The kernel supports this through the sfp and phylink support. SFI is
>more commonly known as 10GBASE-R. Note that this is *not* USXGMII.
>Link status needs to come from the MAC side, so macb_mac_pcs_get_state()
>is required.
>
>> Rate determined by 10GBASE-T PHY capability through auto-negotiation.
>> I2C IP required
>> +--------------+ +-----------+
>> | | | | | SFP+ to |
>> | GEM MAC/DMA | <---> | SerDes | <---- SFI-----> | 10GBASE-T |
>> | USX PCS| | | (PMA) | | |
>> +--------------+ +-----------+
>> ^
>> +--------+ |
>> | I2C | |
>> | Master | <-------------------------------------|
>> +--------+
>
>The 10G copper module I have uses 10GBASE-R, 5000BASE-X, 2500BASE-X,
>and SGMII (without in-band status), dynamically switching between
>these depending on the results of the copper side negotiation.
>
>> USXGMII PHY. Uses MDIO or equivalent for status xfer
>> +-------------+ +--------+
>> | | | | | |
>> | GEM MAC/DMA | <---> | SerDes | <--- USXGMII ---> | PHY |
>> | USX PCS | | (PMA) | | |
>> +-------------+ +--------+
>> ^ ^
>> |_____________________ MDIO ______________________|
>
>Overall, please implement phylink properly for your MAC, rather than
>the current half-hearted approach that *will* break in various
>circumstances.
>
We would need more time to get back on the restructured implementation. While we
work on that, is it okay to accept patch 1/3 and patch 2/3?
next prev parent reply other threads:[~2019-12-20 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 9:40 [PATCH v2 0/3] net: macb: fix for fixed link, support for c45 mdio and 10G Milind Parab
2019-12-13 9:41 ` [PATCH v2 1/3] net: macb: fix for fixed-link mode Milind Parab
2019-12-15 4:33 ` Jakub Kicinski
2019-12-13 9:41 ` [PATCH v2 2/3] net: macb: add support for C45 MDIO read/write Milind Parab
2019-12-15 14:56 ` Andrew Lunn
2019-12-13 9:42 ` [PATCH v2 3/3] net: macb: add support for high speed interface Milind Parab
2019-12-15 15:12 ` Russell King - ARM Linux admin
2019-12-15 15:20 ` Russell King - ARM Linux admin
2019-12-16 12:49 ` Milind Parab
2019-12-16 13:09 ` Russell King - ARM Linux admin
2019-12-16 14:30 ` Russell King - ARM Linux admin
2019-12-20 9:05 ` Milind Parab [this message]
2019-12-21 11:08 ` Milind Parab
2020-01-08 10:32 ` Nicolas.Ferre
2019-12-15 9:49 ` [PATCH v2 0/3] net: macb: fix for fixed link, support for c45 mdio and 10G Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR07MB65143BFFE9D08FBA2BD94669D32D0@BY5PR07MB6514.namprd07.prod.outlook.com \
--to=mparab@cadence.com \
--cc=a.fatoum@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=brad.mouring@ni.com \
--cc=davem@davemloft.net \
--cc=dkangude@cadence.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.nerre@microchip.com \
--cc=pthombar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).