From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: David Miller <davem@davemloft.net>
Cc: jouni.hogander@unikie.com, netdev@vger.kernel.org,
penguin-kernel@I-love.SAKURA.ne.jp, lukas.bulwahn@gmail.com
Subject: Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject
Date: Wed, 18 Dec 2019 10:36:47 +0900 [thread overview]
Message-ID: <201912180136.xBI1alSc017861@www262.sakura.ne.jp> (raw)
In-Reply-To: <20191217.142048.1420015947023495901.davem@davemloft.net>
David Miller wrote:
> From: jouni.hogander@unikie.com
> Date: Tue, 17 Dec 2019 10:44:29 +0200
>
> > From: Jouni Hogander <jouni.hogander@unikie.com>
> >
> > Dev_hold has to be called always in rx_queue_add_kobject.
> > Otherwise usage count drops below 0 in case of failure in
> > kobject_init_and_add.
> >
> > Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Cc: David Miller <davem@davemloft.net>
> > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>
>
> Why are you posting this again, the change is already in my tree?
>
Not posting again. Previous patch was for "netdev_queue_add_kobject" and
this patch is for "rx_queue_add_kobject". Also, Reported-by: in this patch
is wrong. Please apply an updated patch shown below.
Date: Tue, 17 Dec 2019 13:46:34 +0200
Message-Id: <20191217114634.9428-1-jouni.hogander@unikie.com>
next prev parent reply other threads:[~2019-12-18 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 8:44 [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject jouni.hogander
2019-12-17 11:09 ` Tetsuo Handa
2019-12-17 22:20 ` David Miller
2019-12-18 1:36 ` Tetsuo Handa [this message]
2019-12-17 11:46 jouni.hogander
2019-12-18 6:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912180136.xBI1alSc017861@www262.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=davem@davemloft.net \
--cc=jouni.hogander@unikie.com \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).