Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: David Miller <davem@davemloft.net>
To: jouni.hogander@unikie.com
Cc: netdev@vger.kernel.org, penguin-kernel@I-love.SAKURA.ne.jp,
	lukas.bulwahn@gmail.com
Subject: Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject
Date: Tue, 17 Dec 2019 14:20:48 -0800 (PST)
Message-ID: <20191217.142048.1420015947023495901.davem@davemloft.net> (raw)
In-Reply-To: <20191217084429.28001-1-jouni.hogander@unikie.com>

From: jouni.hogander@unikie.com
Date: Tue, 17 Dec 2019 10:44:29 +0200

> From: Jouni Hogander <jouni.hogander@unikie.com>
> 
> Dev_hold has to be called always in rx_queue_add_kobject.
> Otherwise usage count drops below 0 in case of failure in
> kobject_init_and_add.
> 
> Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: David Miller <davem@davemloft.net>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>

Why are you posting this again, the change is already in my tree?

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  8:44 jouni.hogander
2019-12-17 11:09 ` Tetsuo Handa
2019-12-17 22:20 ` David Miller [this message]
2019-12-18  1:36   ` Tetsuo Handa
2019-12-17 11:46 jouni.hogander
2019-12-18  6:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217.142048.1420015947023495901.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jouni.hogander@unikie.com \
    --cc=lukas.bulwahn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git