* [PATCH net] net: phy: aquantia: add suspend / resume ops for AQR105
@ 2019-12-19 14:17 Madalin Bucur
2019-12-21 5:36 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Madalin Bucur @ 2019-12-19 14:17 UTC (permalink / raw)
To: netdev, davem; +Cc: Madalin Bucur
The suspend/resume code for AQR107 works on AQR105 too.
This patch fixes issues with the partner not seeing the link down
when the interface using AQR105 is brought down.
Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
---
drivers/net/phy/aquantia_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c
index 3b29d381116f..975789d9349d 100644
--- a/drivers/net/phy/aquantia_main.c
+++ b/drivers/net/phy/aquantia_main.c
@@ -627,6 +627,8 @@ static struct phy_driver aqr_driver[] = {
.config_intr = aqr_config_intr,
.ack_interrupt = aqr_ack_interrupt,
.read_status = aqr_read_status,
+ .suspend = aqr107_suspend,
+ .resume = aqr107_resume,
},
{
PHY_ID_MATCH_MODEL(PHY_ID_AQR106),
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: aquantia: add suspend / resume ops for AQR105
2019-12-19 14:17 [PATCH net] net: phy: aquantia: add suspend / resume ops for AQR105 Madalin Bucur
@ 2019-12-21 5:36 ` David Miller
2019-12-23 5:56 ` Madalin Bucur
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2019-12-21 5:36 UTC (permalink / raw)
To: madalin.bucur, madalin.bucur; +Cc: netdev
From: Madalin Bucur <madalin.bucur@oss.nxp.com>
Date: Thu, 19 Dec 2019 16:17:02 +0200
> The suspend/resume code for AQR107 works on AQR105 too.
> This patch fixes issues with the partner not seeing the link down
> when the interface using AQR105 is brought down.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
For bug fixes please provide an appropriate Fixes: tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net] net: phy: aquantia: add suspend / resume ops for AQR105
2019-12-21 5:36 ` David Miller
@ 2019-12-23 5:56 ` Madalin Bucur
0 siblings, 0 replies; 3+ messages in thread
From: Madalin Bucur @ 2019-12-23 5:56 UTC (permalink / raw)
To: David Miller, Madalin Bucur (OSS); +Cc: netdev
> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Saturday, December 21, 2019 7:36 AM
> To: Madalin Bucur <madalin.bucur@nxp.com>; Madalin Bucur (OSS)
> <madalin.bucur@oss.nxp.com>
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH net] net: phy: aquantia: add suspend / resume ops for
> AQR105
>
> From: Madalin Bucur <madalin.bucur@oss.nxp.com>
> Date: Thu, 19 Dec 2019 16:17:02 +0200
>
> > The suspend/resume code for AQR107 works on AQR105 too.
> > This patch fixes issues with the partner not seeing the link down
> > when the interface using AQR105 is brought down.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
>
> For bug fixes please provide an appropriate Fixes: tag.
This fixes an issue with the link remaining on when the interface
is brought down that was there since the support for the PHY was
added so this may be a fix to that initial submission:
Fixes: bee8259dd31f4 ("net: phy: add driver for aquantia phy")
or it may be the commit that added suspend resume support only for
AQR107 although it applies to AQR105 too:
Fixes: ac9e81c230eb4 ("net: phy: aquantia: add suspend / resume
callbacks for AQR107 family")
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-23 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 14:17 [PATCH net] net: phy: aquantia: add suspend / resume ops for AQR105 Madalin Bucur
2019-12-21 5:36 ` David Miller
2019-12-23 5:56 ` Madalin Bucur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).