* [PATCH net] selftests: pmtu: fix init mtu value in description
@ 2019-12-20 7:08 Hangbin Liu
2019-12-20 7:35 ` Stefano Brivio
2019-12-21 5:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2019-12-20 7:08 UTC (permalink / raw)
To: netdev; +Cc: Sabrina Dubroca, Stefano Brivio, David S . Miller, Hangbin Liu
There is no a_r3, a_r4 in the testing topology.
It should be b_r1, b_r2. Also b_r1 mtu is 1400 and b_r2 mtu is 1500.
Fixes: e44e428f59e4 ("selftests: pmtu: add basic IPv4 and IPv6 PMTU tests")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/pmtu.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index d697815d2785..71a62e7e35b1 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -11,9 +11,9 @@
# R1 and R2 (also implemented with namespaces), with different MTUs:
#
# segment a_r1 segment b_r1 a_r1: 2000
-# .--------------R1--------------. a_r2: 1500
-# A B a_r3: 2000
-# '--------------R2--------------' a_r4: 1400
+# .--------------R1--------------. b_r1: 1400
+# A B a_r2: 2000
+# '--------------R2--------------' b_r2: 1500
# segment a_r2 segment b_r2
#
# Check that PMTU exceptions with the correct PMTU are created. Then
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: pmtu: fix init mtu value in description
2019-12-20 7:08 [PATCH net] selftests: pmtu: fix init mtu value in description Hangbin Liu
@ 2019-12-20 7:35 ` Stefano Brivio
2019-12-21 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2019-12-20 7:35 UTC (permalink / raw)
To: Hangbin Liu; +Cc: netdev, Sabrina Dubroca, David S . Miller
On Fri, 20 Dec 2019 15:08:06 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> There is no a_r3, a_r4 in the testing topology.
Oops :)
> It should be b_r1, b_r2. Also b_r1 mtu is 1400 and b_r2 mtu is 1500.
>
> Fixes: e44e428f59e4 ("selftests: pmtu: add basic IPv4 and IPv6 PMTU tests")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: pmtu: fix init mtu value in description
2019-12-20 7:08 [PATCH net] selftests: pmtu: fix init mtu value in description Hangbin Liu
2019-12-20 7:35 ` Stefano Brivio
@ 2019-12-21 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-12-21 5:52 UTC (permalink / raw)
To: liuhangbin; +Cc: netdev, sd, sbrivio
From: Hangbin Liu <liuhangbin@gmail.com>
Date: Fri, 20 Dec 2019 15:08:06 +0800
> There is no a_r3, a_r4 in the testing topology.
> It should be b_r1, b_r2. Also b_r1 mtu is 1400 and b_r2 mtu is 1500.
>
> Fixes: e44e428f59e4 ("selftests: pmtu: add basic IPv4 and IPv6 PMTU tests")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-21 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 7:08 [PATCH net] selftests: pmtu: fix init mtu value in description Hangbin Liu
2019-12-20 7:35 ` Stefano Brivio
2019-12-21 5:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).