* [PATCH next] net/wan/fsl_ucc_hdlc: remove set but not used variables 'ut_info' and 'ret'
@ 2019-12-28 3:09 Chen Zhou
2019-12-28 19:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2019-12-28 3:09 UTC (permalink / raw)
To: qiang.zhao, davem; +Cc: netdev, linux-kernel, chenzhou10
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wan/fsl_ucc_hdlc.c: In function ucc_hdlc_irq_handler:
drivers/net/wan/fsl_ucc_hdlc.c:643:23:
warning: variable ut_info set but not used [-Wunused-but-set-variable]
drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_suspend:
drivers/net/wan/fsl_ucc_hdlc.c:880:23:
warning: variable ut_info set but not used [-Wunused-but-set-variable]
drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_resume:
drivers/net/wan/fsl_ucc_hdlc.c:925:6:
warning: variable ret set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/wan/fsl_ucc_hdlc.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 8d6ec33..49b1aaf 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -640,11 +640,9 @@ static irqreturn_t ucc_hdlc_irq_handler(int irq, void *dev_id)
struct ucc_hdlc_private *priv = (struct ucc_hdlc_private *)dev_id;
struct net_device *dev = priv->ndev;
struct ucc_fast_private *uccf;
- struct ucc_tdm_info *ut_info;
u32 ucce;
u32 uccm;
- ut_info = priv->ut_info;
uccf = priv->uccf;
ucce = ioread32be(uccf->p_ucce);
@@ -877,7 +875,6 @@ static void resume_clk_config(struct ucc_hdlc_private *priv)
static int uhdlc_suspend(struct device *dev)
{
struct ucc_hdlc_private *priv = dev_get_drvdata(dev);
- struct ucc_tdm_info *ut_info;
struct ucc_fast __iomem *uf_regs;
if (!priv)
@@ -889,7 +886,6 @@ static int uhdlc_suspend(struct device *dev)
netif_device_detach(priv->ndev);
napi_disable(&priv->napi);
- ut_info = priv->ut_info;
uf_regs = priv->uf_regs;
/* backup gumr guemr*/
@@ -922,7 +918,7 @@ static int uhdlc_resume(struct device *dev)
struct ucc_fast __iomem *uf_regs;
struct ucc_fast_private *uccf;
struct ucc_fast_info *uf_info;
- int ret, i;
+ int i;
u32 cecr_subblock;
u16 bd_status;
@@ -967,7 +963,7 @@ static int uhdlc_resume(struct device *dev)
/* Write to QE CECR, UCCx channel to Stop Transmission */
cecr_subblock = ucc_fast_get_qe_cr_subblock(uf_info->ucc_num);
- ret = qe_issue_cmd(QE_STOP_TX, cecr_subblock,
+ qe_issue_cmd(QE_STOP_TX, cecr_subblock,
(u8)QE_CR_PROTOCOL_UNSPECIFIED, 0);
/* Set UPSMR normal mode */
@@ -975,7 +971,7 @@ static int uhdlc_resume(struct device *dev)
/* init parameter base */
cecr_subblock = ucc_fast_get_qe_cr_subblock(uf_info->ucc_num);
- ret = qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, cecr_subblock,
+ qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, cecr_subblock,
QE_CR_PROTOCOL_UNSPECIFIED, priv->ucc_pram_offset);
priv->ucc_pram = (struct ucc_hdlc_param __iomem *)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] net/wan/fsl_ucc_hdlc: remove set but not used variables 'ut_info' and 'ret'
2019-12-28 3:09 [PATCH next] net/wan/fsl_ucc_hdlc: remove set but not used variables 'ut_info' and 'ret' Chen Zhou
@ 2019-12-28 19:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-28 19:34 UTC (permalink / raw)
To: chenzhou10; +Cc: qiang.zhao, netdev, linux-kernel
From: Chen Zhou <chenzhou10@huawei.com>
Date: Sat, 28 Dec 2019 11:09:47 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wan/fsl_ucc_hdlc.c: In function ucc_hdlc_irq_handler:
> drivers/net/wan/fsl_ucc_hdlc.c:643:23:
> warning: variable ut_info set but not used [-Wunused-but-set-variable]
> drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_suspend:
> drivers/net/wan/fsl_ucc_hdlc.c:880:23:
> warning: variable ut_info set but not used [-Wunused-but-set-variable]
> drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_resume:
> drivers/net/wan/fsl_ucc_hdlc.c:925:6:
> warning: variable ret set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-28 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-28 3:09 [PATCH next] net/wan/fsl_ucc_hdlc: remove set but not used variables 'ut_info' and 'ret' Chen Zhou
2019-12-28 19:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).