[PATCH net-next] fcnal-test: Fix vrf argument in local tcp tests

[PATCH net-next] fcnal-test: Fix vrf argument in local tcp tests

[David Ahern]

From: David Ahern <dsahern@gmail.com>

The recent MD5 tests added duplicate configuration in the default VRF.
This change exposed a bug in existing tests designed to verify no
connection when client and server are not in the same domain. The
server should be running bound to the vrf device with the client run
in the default VRF (the -2 option is meant for validating connection
data). Fix the option for both tests.

While technically this is a bug in previous releases, the tests are
properly failing since the default VRF does not have any routing
configuration so there really is no need to backport to prior releases.

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 tools/testing/selftests/net/fcnal-test.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 15cb8ab68c7c..fb5c55dd6df8 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -1165,8 +1165,8 @@ ipv4_tcp_vrf()
 	for a in ${NSA_IP} ${VRF_IP}
 	do
 		log_start
-		show_hint "Should fail 'No route to host' since client is not bound to VRF"
-		run_cmd nettest -s -2 ${VRF} &
+		show_hint "Should fail 'Connection refused' since client is not bound to VRF"
+		run_cmd nettest -s -d ${VRF} &
 		sleep 1
 		run_cmd nettest -r ${a}
 		log_test_addr ${a} $? 1 "Global server, local connection"
@@ -2663,8 +2663,8 @@ ipv6_tcp_vrf()
 	for a in ${NSA_IP6} ${VRF_IP6}
 	do
 		log_start
-		show_hint "Fails 'No route to host' since client is not in VRF"
-		run_cmd nettest -6 -s -2 ${VRF} &
+		show_hint "Fails 'Connection refused' since client is not in VRF"
+		run_cmd nettest -6 -s -d ${VRF} &
 		sleep 1
 		run_cmd nettest -6 -r ${a}
 		log_test_addr ${a} $? 1 "Global server, local connection"
-- 
2.11.0

Re: [PATCH net-next] fcnal-test: Fix vrf argument in local tcp tests

[David Miller]

From: David Ahern <dsahern@kernel.org>
Date: Sun,  5 Jan 2020 20:02:05 -0800

> From: David Ahern <dsahern@gmail.com>
> 
> The recent MD5 tests added duplicate configuration in the default VRF.
> This change exposed a bug in existing tests designed to verify no
> connection when client and server are not in the same domain. The
> server should be running bound to the vrf device with the client run
> in the default VRF (the -2 option is meant for validating connection
> data). Fix the option for both tests.
> 
> While technically this is a bug in previous releases, the tests are
> properly failing since the default VRF does not have any routing
> configuration so there really is no need to backport to prior releases.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Applied.