netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE
@ 2020-01-13  9:28 Lorenzo Bianconi
  2020-01-13 10:38 ` Jesper Dangaard Brouer
  2020-01-14  2:14 ` Jakub Kicinski
  0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2020-01-13  9:28 UTC (permalink / raw)
  To: netdev; +Cc: lorenzo.bianconi, davem, brouer

With 'commit 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE
condition")' we can safely change nid to NUMA_NO_NODE and accommodate
future NUMA aware hardware using mvneta network interface

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index dcf831005ce6..4b4b2177982d 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3072,7 +3072,7 @@ static int mvneta_create_page_pool(struct mvneta_port *pp,
 		.order = 0,
 		.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,
 		.pool_size = size,
-		.nid = cpu_to_node(0),
+		.nid = NUMA_NO_NODE,
 		.dev = pp->dev->dev.parent,
 		.dma_dir = xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE,
 		.offset = pp->rx_offset_correction,
-- 
2.21.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE
  2020-01-13  9:28 [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE Lorenzo Bianconi
@ 2020-01-13 10:38 ` Jesper Dangaard Brouer
  2020-01-14  2:14 ` Jakub Kicinski
  1 sibling, 0 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2020-01-13 10:38 UTC (permalink / raw)
  To: Lorenzo Bianconi; +Cc: netdev, lorenzo.bianconi, davem, brouer

On Mon, 13 Jan 2020 10:28:12 +0100
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> With 'commit 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE
> condition")' we can safely change nid to NUMA_NO_NODE and accommodate
> future NUMA aware hardware using mvneta network interface
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE
  2020-01-13  9:28 [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE Lorenzo Bianconi
  2020-01-13 10:38 ` Jesper Dangaard Brouer
@ 2020-01-14  2:14 ` Jakub Kicinski
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-01-14  2:14 UTC (permalink / raw)
  To: Lorenzo Bianconi; +Cc: netdev, lorenzo.bianconi, davem, brouer

On Mon, 13 Jan 2020 10:28:12 +0100, Lorenzo Bianconi wrote:
> With 'commit 44768decb7c0 ("page_pool: handle page recycle for NUMA_NO_NODE
> condition")' we can safely change nid to NUMA_NO_NODE and accommodate
> future NUMA aware hardware using mvneta network interface
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Applied, thank you!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-14  2:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13  9:28 [PATCH] net: mvneta: change page pool nid to NUMA_NO_NODE Lorenzo Bianconi
2020-01-13 10:38 ` Jesper Dangaard Brouer
2020-01-14  2:14 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).