[PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down

[PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down

[Vladimir Oltean]

From: Vladimir Oltean <vladimir.oltean@nxp.com>

It is not an error to unplug a cable from the ENETC port even with TSN
offloads, so don't spam the log with link-related messages from the
tc-taprio offload subsystem, a single notification is sufficient:

[10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
[10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down

Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc_qos.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 00382b7c5bd8..0c6bf3a55a9a 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -36,7 +36,6 @@ void enetc_sched_speed_set(struct net_device *ndev)
 	case SPEED_10:
 	default:
 		pspeed = ENETC_PMR_PSPEED_10M;
-		netdev_err(ndev, "Qbv PSPEED set speed link down.\n");
 	}
 
 	priv->speed = speed;
-- 
2.17.1

Re: [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down

[Andrew Lunn]

On Thu, Jan 16, 2020 at 07:18:28PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> It is not an error to unplug a cable from the ENETC port even with TSN
> offloads, so don't spam the log with link-related messages from the
> tc-taprio offload subsystem, a single notification is sufficient:
> 
> [10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
> [10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
> 
> Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down

[David Miller]

From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 16 Jan 2020 19:18:28 +0200

> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> It is not an error to unplug a cable from the ENETC port even with TSN
> offloads, so don't spam the log with link-related messages from the
> tc-taprio offload subsystem, a single notification is sufficient:
> 
> [10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
> [10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
> 
> Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Applied, thanks.