* [PATCH net-next] net: dsa: felix: Set USXGMII link based on BMSR, not LPA
@ 2020-01-16 18:05 Vladimir Oltean
2020-01-17 12:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2020-01-16 18:05 UTC (permalink / raw)
To: davem, netdev, linux
Cc: andrew, f.fainelli, vivien.didelot, claudiu.manoil,
Alex Marginean, Vladimir Oltean
From: Alex Marginean <alexandru.marginean@nxp.com>
At least some PHYs (AQR412) don't advertise copper-side link status
during system side AN.
So remove this duplicate assignment to pcs->link and rely on the
previous one for link state: the local indication from the MAC PCS.
Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/dsa/ocelot/felix_vsc9959.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 03482616faa7..1e82b0d72058 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -892,7 +892,6 @@ static void vsc9959_pcs_link_state_usxgmii(struct phy_device *pcs,
break;
}
- pcs->link = USXGMII_LPA_LNKS(lpa);
if (USXGMII_LPA_DUPLEX(lpa))
pcs->duplex = DUPLEX_FULL;
else
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: dsa: felix: Set USXGMII link based on BMSR, not LPA
2020-01-16 18:05 [PATCH net-next] net: dsa: felix: Set USXGMII link based on BMSR, not LPA Vladimir Oltean
@ 2020-01-17 12:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-17 12:15 UTC (permalink / raw)
To: olteanv
Cc: netdev, linux, andrew, f.fainelli, vivien.didelot,
claudiu.manoil, alexandru.marginean, vladimir.oltean
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 16 Jan 2020 20:05:06 +0200
> From: Alex Marginean <alexandru.marginean@nxp.com>
>
> At least some PHYs (AQR412) don't advertise copper-side link status
> during system side AN.
>
> So remove this duplicate assignment to pcs->link and rely on the
> previous one for link state: the local indication from the MAC PCS.
>
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-19 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 18:05 [PATCH net-next] net: dsa: felix: Set USXGMII link based on BMSR, not LPA Vladimir Oltean
2020-01-17 12:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).