From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk, andrew@lunn.ch,
f.fainelli@gmail.com, vivien.didelot@gmail.com,
claudiu.manoil@nxp.com, alexandru.marginean@nxp.com,
vladimir.oltean@nxp.com
Subject: Re: [PATCH v2 net-next] net: dsa: felix: Don't error out on disabled ports with no phy-mode
Date: Fri, 17 Jan 2020 04:23:53 -0800 (PST) [thread overview]
Message-ID: <20200117.042353.544899187026083387.davem@davemloft.net> (raw)
In-Reply-To: <20200116184153.12301-1-olteanv@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 16 Jan 2020 20:41:53 +0200
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> The felix_parse_ports_node function was tested only on device trees
> where all ports were enabled. Fix this check so that the driver
> continues to probe only with the ports where status is not "disabled",
> as expected.
>
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Changes in v2:
> - Use for_each_available_child_of_node instead of open-coding the
> of_device_is_available check.
Applied.
prev parent reply other threads:[~2020-01-19 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 18:41 [PATCH v2 net-next] net: dsa: felix: Don't error out on disabled ports with no phy-mode Vladimir Oltean
2020-01-16 18:47 ` Florian Fainelli
2020-01-16 20:52 ` Andrew Lunn
2020-01-17 12:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117.042353.544899187026083387.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).