[PATCH net-next] net: phylink: allow in-band AN for USXGMII

[PATCH net-next] net: phylink: allow in-band AN for USXGMII

[Vladimir Oltean]

From: Alex Marginean <alexandru.marginean@nxp.com>

USXGMII supports passing link information in-band between PHY and MAC PCS,
add it to the list of protocols that support in-band AN mode.

Being a MAC-PHY protocol that can auto-negotiate link speeds up to 10
Gbps, we populate the initial supported mask with the entire spectrum of
link modes up to 10G that PHYLINK supports, and we let the driver reduce
that mask in its .phylink_validate method.

Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/phy/phylink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index efabbfa4a6d3..f40d92ec32f8 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -299,6 +299,7 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
 			break;
 
 		case PHY_INTERFACE_MODE_10GKR:
+		case PHY_INTERFACE_MODE_USXGMII:
 		case PHY_INTERFACE_MODE_10GBASER:
 			phylink_set(pl->supported, 10baseT_Half);
 			phylink_set(pl->supported, 10baseT_Full);
-- 
2.17.1

Re: [PATCH net-next] net: phylink: allow in-band AN for USXGMII

[Russell King - ARM Linux admin]

On Thu, Jan 16, 2020 at 07:39:30PM +0200, Vladimir Oltean wrote:
> From: Alex Marginean <alexandru.marginean@nxp.com>
> 
> USXGMII supports passing link information in-band between PHY and MAC PCS,
> add it to the list of protocols that support in-band AN mode.
> 
> Being a MAC-PHY protocol that can auto-negotiate link speeds up to 10
> Gbps, we populate the initial supported mask with the entire spectrum of
> link modes up to 10G that PHYLINK supports, and we let the driver reduce
> that mask in its .phylink_validate method.
> 
> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Please copy your patches to the netdev mailing list.

> ---
>  drivers/net/phy/phylink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index efabbfa4a6d3..f40d92ec32f8 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -299,6 +299,7 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
>  			break;
>  
>  		case PHY_INTERFACE_MODE_10GKR:
> +		case PHY_INTERFACE_MODE_USXGMII:
>  		case PHY_INTERFACE_MODE_10GBASER:

Please also move USXGMII before 10GKR.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up