From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Mark Starovoytov <mstarovoitov@marvell.com>,
Dmitry Bogdanov <dbogdanov@marvell.com>
Subject: Re: [RFC 09/18] net: macsec: add support for getting offloaded stats
Date: Fri, 21 Feb 2020 18:48:20 +0100 [thread overview]
Message-ID: <20200221174820.GD3530@kwain> (raw)
In-Reply-To: <20200214150258.390-10-irusskikh@marvell.com>
Hello,
On Fri, Feb 14, 2020 at 06:02:49PM +0300, Igor Russkikh wrote:
> From: Dmitry Bogdanov <dbogdanov@marvell.com>
>
> report sw stats only if offloaded stats are not supported
Please improve the changelog.
> -static int copy_tx_sa_stats(struct sk_buff *skb,
> - struct macsec_tx_sa_stats __percpu *pstats)
> +static void get_tx_sa_stats(struct net_device *dev, int an,
> + struct macsec_tx_sa *tx_sa,
> + struct macsec_tx_sa_stats *sum)
> {
> - struct macsec_tx_sa_stats sum = {0, };
> + struct macsec_dev *macsec = macsec_priv(dev);
> + int err = -EOPNOTSUPP;
> int cpu;
>
> + /* If h/w offloading is available, propagate to the device */
> + if (macsec_is_offloaded(macsec)) {
> + const struct macsec_ops *ops;
> + struct macsec_context ctx;
> +
> + ops = macsec_get_ops(macsec, &ctx);
> + if (ops) {
> + ctx.sa.assoc_num = an;
> + ctx.sa.tx_sa = tx_sa;
> + ctx.stats.tx_sa_stats = sum;
> + ctx.secy = &macsec_priv(dev)->secy;
> + err = macsec_offload(ops->mdo_get_tx_sa_stats, &ctx);
> + }
> + }
> +
> + if (err != -EOPNOTSUPP)
> + return;
If offloading is enabled and ops->mdo_get_tx_sa_stats is returning
-EOPNOTSUPP, do we really want to return the s/w stats as they'll be
wrong and out of sync with the hardware anyway?
(The same applies for the other statistics retrieval in the same patch).
> +
> for_each_possible_cpu(cpu) {
> - const struct macsec_tx_sa_stats *stats = per_cpu_ptr(pstats, cpu);
> + const struct macsec_tx_sa_stats *stats =
> + per_cpu_ptr(tx_sa->stats, cpu);
>
> - sum.OutPktsProtected += stats->OutPktsProtected;
> - sum.OutPktsEncrypted += stats->OutPktsEncrypted;
> + sum->OutPktsProtected += stats->OutPktsProtected;
> + sum->OutPktsEncrypted += stats->OutPktsEncrypted;
> }
> +}
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-21 17:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 15:02 [RFC 00/18] net: atlantic: MACSec support for AQC devices Igor Russkikh
2020-02-14 15:02 ` [RFC 01/18] net: introduce the MACSEC netdev feature Igor Russkikh
2020-02-14 15:02 ` [RFC 02/18] net: add a reference to MACsec ops in net_device Igor Russkikh
2020-02-14 15:02 ` [RFC 03/18] net: macsec: allow to reference a netdev from a MACsec context Igor Russkikh
2020-02-14 15:02 ` [RFC 04/18] net: macsec: add support for offloading to the MAC Igor Russkikh
2020-02-14 15:02 ` [RFC 05/18] net: macsec: init secy pointer in macsec_context Igor Russkikh
2020-02-21 15:09 ` Antoine Tenart
2020-02-14 15:02 ` [RFC 06/18] net: macsec: invoke mdo_upd_secy callback when mac address changed Igor Russkikh
2020-02-21 15:07 ` Antoine Tenart
2020-02-14 15:02 ` [RFC 07/18] net: macsec: allow multiple macsec devices with offload Igor Russkikh
2020-02-14 15:02 ` [RFC 08/18] net: macsec: support multicast/broadcast when offloading Igor Russkikh
2020-02-14 15:02 ` [RFC 09/18] net: macsec: add support for getting offloaded stats Igor Russkikh
2020-02-21 17:48 ` Antoine Tenart [this message]
2020-02-14 15:02 ` [RFC 10/18] net: macsec: enable HW offloading by default (when available) Igor Russkikh
2020-02-21 18:04 ` Antoine Tenart
2020-02-14 15:02 ` [RFC 11/18] net: macsec: report real_dev features when HW offloading is enabled Igor Russkikh
2020-02-14 15:02 ` [RFC 12/18] net: atlantic: MACSec offload skeleton Igor Russkikh
2020-02-21 18:21 ` Antoine Tenart
2020-02-14 15:02 ` [RFC 13/18] net: atlantic: MACSec egress offload HW bindings Igor Russkikh
2020-02-14 15:02 ` [RFC 14/18] net: atlantic: MACSec egress offload implementation Igor Russkikh
2020-02-14 15:02 ` [RFC 15/18] net: atlantic: MACSec ingress offload HW bindings Igor Russkikh
2020-02-14 15:02 ` [RFC 16/18] net: atlantic: MACSec ingress offload implementation Igor Russkikh
2020-02-14 15:02 ` [RFC 17/18] net: atlantic: MACSec offload statistics HW bindings Igor Russkikh
2020-02-14 15:02 ` [RFC 18/18] net: atlantic: MACSec offload statistics implementation Igor Russkikh
2020-02-21 14:57 ` [RFC 00/18] net: atlantic: MACSec support for AQC devices Antoine Tenart
2020-02-26 8:12 ` [EXT] " Igor Russkikh
2020-02-26 15:50 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221174820.GD3530@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=dbogdanov@marvell.com \
--cc=irusskikh@marvell.com \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).