* [PATCH] tun: Remove unnecessary BUG_ON check in tun_net_xmit
@ 2020-02-21 19:53 David Ahern
2020-02-21 19:54 ` [PATCH net-next] " David Ahern
2020-02-24 0:41 ` [PATCH] " David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2020-02-21 19:53 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, David Ahern, Jason Wang
From: David Ahern <dsahern@gmail.com>
The BUG_ON for NULL tfile is now redundant due to a recently
added null check after the rcu_dereference. Remove the BUG_ON.
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
---
drivers/net/tun.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 650c937ed56b..79f248cb282d 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1078,8 +1078,6 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
tun_debug(KERN_INFO, tun, "tun_net_xmit %d\n", skb->len);
- BUG_ON(!tfile);
-
/* Drop if the filter does not like it.
* This is a noop if the filter is disabled.
* Filter can be enabled only for the TAP devices. */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tun: Remove unnecessary BUG_ON check in tun_net_xmit
2020-02-21 19:53 [PATCH] tun: Remove unnecessary BUG_ON check in tun_net_xmit David Ahern
@ 2020-02-21 19:54 ` David Ahern
2020-02-24 0:41 ` [PATCH] " David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2020-02-21 19:54 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, Jason Wang
On 2/21/20 12:53 PM, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
>
> The BUG_ON for NULL tfile is now redundant due to a recently
> added null check after the rcu_dereference. Remove the BUG_ON.
>
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> drivers/net/tun.c | 2 --
> 1 file changed, 2 deletions(-)
>
D'oh. Forgot the net-next label
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tun: Remove unnecessary BUG_ON check in tun_net_xmit
2020-02-21 19:53 [PATCH] tun: Remove unnecessary BUG_ON check in tun_net_xmit David Ahern
2020-02-21 19:54 ` [PATCH net-next] " David Ahern
@ 2020-02-24 0:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-02-24 0:41 UTC (permalink / raw)
To: dsahern; +Cc: netdev, kuba, dsahern, jasowang
From: David Ahern <dsahern@kernel.org>
Date: Fri, 21 Feb 2020 12:53:09 -0700
> From: David Ahern <dsahern@gmail.com>
>
> The BUG_ON for NULL tfile is now redundant due to a recently
> added null check after the rcu_dereference. Remove the BUG_ON.
>
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied to net-next, thanks David.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-24 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 19:53 [PATCH] tun: Remove unnecessary BUG_ON check in tun_net_xmit David Ahern
2020-02-21 19:54 ` [PATCH net-next] " David Ahern
2020-02-24 0:41 ` [PATCH] " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).