* [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec
@ 2020-02-24 23:56 Florian Fainelli
2020-02-25 15:24 ` Vivien Didelot
2020-02-27 0:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-02-24 23:56 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Andrew Lunn, Vivien Didelot, David S. Miller,
open list
We are still experiencing some packet loss with the existing advanced
congestion buffering (ACB) settings with the IMP port configured for
2Gb/sec, so revert to conservative link speeds that do not produce
packet loss until this is resolved.
Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/bcm_sf2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index d1955543acd1..b0f5280a83cb 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -69,8 +69,7 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)
/* Force link status for IMP port */
reg = core_readl(priv, offset);
reg |= (MII_SW_OR | LINK_STS);
- if (priv->type == BCM7278_DEVICE_ID)
- reg |= GMII_SPEED_UP_2G;
+ reg &= ~GMII_SPEED_UP_2G;
core_writel(priv, reg, offset);
/* Enable Broadcast, Multicast, Unicast forwarding to IMP port */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec
2020-02-24 23:56 [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec Florian Fainelli
@ 2020-02-25 15:24 ` Vivien Didelot
2020-02-27 0:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2020-02-25 15:24 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Florian Fainelli, Andrew Lunn, David S. Miller, open list
On Mon, 24 Feb 2020 15:56:32 -0800, Florian Fainelli <f.fainelli@gmail.com> wrote:
> We are still experiencing some packet loss with the existing advanced
> congestion buffering (ACB) settings with the IMP port configured for
> 2Gb/sec, so revert to conservative link speeds that do not produce
> packet loss until this is resolved.
>
> Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
> Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec
2020-02-24 23:56 [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec Florian Fainelli
2020-02-25 15:24 ` Vivien Didelot
@ 2020-02-27 0:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-02-27 0:39 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 24 Feb 2020 15:56:32 -0800
> We are still experiencing some packet loss with the existing advanced
> congestion buffering (ACB) settings with the IMP port configured for
> 2Gb/sec, so revert to conservative link speeds that do not produce
> packet loss until this is resolved.
>
> Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
> Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied and queued up for v5.5 -stable.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 0:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 23:56 [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec Florian Fainelli
2020-02-25 15:24 ` Vivien Didelot
2020-02-27 0:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).