* [PATCH v3] slip: not call free_netdev before rtnl_unlock in slip_open
@ 2020-02-26 12:17 yangerkun
0 siblings, 0 replies; only message in thread
From: yangerkun @ 2020-02-26 12:17 UTC (permalink / raw)
To: davem, socketcan; +Cc: netdev, maowenan, yangerkun
As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.
Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
drivers/net/slip/slip.c | 2 ++
1 file changed, 2 insertions(+)
v2->v3:
delete comment exist in v2
diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
index 6f4d7ba8b109..0d2d8c78635e 100644
--- a/drivers/net/slip/slip.c
+++ b/drivers/net/slip/slip.c
@@ -863,7 +863,9 @@ static int slip_open(struct tty_struct *tty)
tty->disc_data = NULL;
clear_bit(SLF_INUSE, &sl->flags);
sl_free_netdev(sl->dev);
+ rtnl_unlock();
free_netdev(sl->dev);
+ return err;
err_exit:
rtnl_unlock();
--
2.23.0.rc2.8.gff66981f45
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-26 12:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 12:17 [PATCH v3] slip: not call free_netdev before rtnl_unlock in slip_open yangerkun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).