From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: lesliemonis@gmail.com, netdev@vger.kernel.org,
tahiliani@nitk.edu.in, gautamramk@gmail.com
Subject: Re: [PATCH net-next v2 0/4] pie: minor improvements
Date: Wed, 04 Mar 2020 13:26:11 -0800 (PST) [thread overview]
Message-ID: <20200304.132611.1082983925572874313.davem@davemloft.net> (raw)
In-Reply-To: <20200304124917.0fbba371@kicinski-fedora-PC1C0HJN>
From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 4 Mar 2020 12:49:17 -0800
> On Thu, 5 Mar 2020 00:25:58 +0530 Leslie Monis wrote:
>> This patch series includes the following minor changes with
>> respect to the PIE/FQ-PIE qdiscs:
>>
>> - Patch 1 removes some ambiguity by using the term "backlog"
>> instead of "qlen" when referring to the queue length
>> in bytes.
>> - Patch 2 removes redundant type casting on two expressions.
>> - Patch 3 removes the pie_vars->accu_prob_overflows variable
>> without affecting the precision in calculations and
>> makes the size of the pie_vars structure exactly 64
>> bytes.
>> - Patch 4 realigns a comment affected by a change in patch 3.
>>
>> Changes from v1 to v2:
>> - Kept 8 as the argument to prandom_bytes() instead of changing it
>> to 7 as suggested by David Miller.
>
> I was wondering if patch 3 changes make user-visible changes but it
> seems those should be only slight accuracy adjustments, so LGTM. FWIW:
>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Series applied, thanks everyone.
prev parent reply other threads:[~2020-03-04 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 18:55 [PATCH net-next v2 0/4] pie: minor improvements Leslie Monis
2020-03-04 18:55 ` [PATCH net-next v2 1/4] pie: use term backlog instead of qlen Leslie Monis
2020-03-04 18:56 ` [PATCH net-next v2 2/4] pie: remove unnecessary type casting Leslie Monis
2020-03-04 18:56 ` [PATCH net-next v2 3/4] pie: remove pie_vars->accu_prob_overflows Leslie Monis
2020-03-04 18:56 ` [PATCH net-next v2 4/4] pie: realign comment Leslie Monis
2020-03-04 20:49 ` [PATCH net-next v2 0/4] pie: minor improvements Jakub Kicinski
2020-03-04 21:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304.132611.1082983925572874313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gautamramk@gmail.com \
--cc=kuba@kernel.org \
--cc=lesliemonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tahiliani@nitk.edu.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).