[PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual

[PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual

[Parav Pandit]

Currently PCI PF and VF devlink devices register their ports as
physical port in non-representors mode.

Introduce a new port flavour as virtual so that virtual devices can
register 'virtual' flavour to make it more clear to users.

An example of one PCI PF and 2 PCI virtual functions, each having
one devlink port.

$ devlink port show
pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0



Parav Pandit (2):
  Update devlink kernel header
  devlink: Introduce devlink port flavour virtual

 devlink/devlink.c            | 2 ++
 include/uapi/linux/devlink.h | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.19.2

[PATCH net-next iproute2 1/2] Update devlink kernel header

[Parav Pandit]

Update devlink kernel header to commit:
acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")

Signed-off-by: Parav Pandit <parav@mellanox.com>
---
 include/uapi/linux/devlink.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 3f82dedd..1b412281 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -187,6 +187,7 @@ enum devlink_port_flavour {
 				      * for the PCI VF. It is an internal
 				      * port that faces the PCI VF.
 				      */
+	DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
 };
 
 enum devlink_param_cmode {
@@ -252,6 +253,8 @@ enum devlink_trap_type {
 enum {
 	/* Trap can report input port as metadata */
 	DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
+	/* Trap can report flow action cookie as metadata */
+	DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
 };
 
 enum devlink_attr {
-- 
2.19.2

[PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual

[Parav Pandit]

Currently PCI PF and VF devlink devices register their ports as
physical port in non-representors mode.

Introduce a new port flavour as virtual so that virtual devices can
register 'virtual' flavour to make it more clear to users.

An example of one PCI PF and 2 PCI virtual functions, each having
one devlink port.

$ devlink port show
pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0

Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
---
 devlink/devlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 6e2115b6..ea9f54c9 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -3150,6 +3150,8 @@ static const char *port_flavour_name(uint16_t flavour)
 		return "pcipf";
 	case DEVLINK_PORT_FLAVOUR_PCI_VF:
 		return "pcivf";
+	case DEVLINK_PORT_FLAVOUR_VIRTUAL:
+		return "virtual";
 	default:
 		return "<unknown flavour>";
 	}
-- 
2.19.2

Re: [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual

[David Ahern]

On 3/3/20 9:06 PM, Parav Pandit wrote:
> Currently PCI PF and VF devlink devices register their ports as
> physical port in non-representors mode.
> 
> Introduce a new port flavour as virtual so that virtual devices can
> register 'virtual' flavour to make it more clear to users.
> 
> An example of one PCI PF and 2 PCI virtual functions, each having
> one devlink port.
> 
> $ devlink port show
> pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
> pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
> pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0
> 
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> ---
>  devlink/devlink.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
applied to iproute2-next. Thanks

Re: [PATCH net-next iproute2 1/2] Update devlink kernel header

[Jacob Keller]

On 3/3/2020 8:06 PM, Parav Pandit wrote:
> Update devlink kernel header to commit:
> acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")
> 
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> ---
>  include/uapi/linux/devlink.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index 3f82dedd..1b412281 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -187,6 +187,7 @@ enum devlink_port_flavour {
>  				      * for the PCI VF. It is an internal
>  				      * port that faces the PCI VF.
>  				      */
> +	DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
>  };
>  
>  enum devlink_param_cmode {
> @@ -252,6 +253,8 @@ enum devlink_trap_type {
>  enum {
>  	/* Trap can report input port as metadata */
>  	DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
> +	/* Trap can report flow action cookie as metadata */
> +	DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
>  };
>  

This hunk doesn't seem relevant to the patch and isn't mentioned in the
subject or description.

Thanks,
Jake

>  enum devlink_attr {
> 

Re: [PATCH net-next iproute2 1/2] Update devlink kernel header

[David Ahern]

On 3/5/20 5:42 PM, Jacob Keller wrote:
> This hunk doesn't seem relevant to the patch and isn't mentioned in the
> subject or description.

it was a sync of the header file. I drop those changes and do full uapi
sync for iproute2 and then apply patches.

Re: [PATCH net-next iproute2 1/2] Update devlink kernel header

[Jacob Keller]

On 3/5/2020 4:42 PM, Jacob Keller wrote:
> 
> 
> On 3/3/2020 8:06 PM, Parav Pandit wrote:
>> Update devlink kernel header to commit:
>> acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")
>>
>> Signed-off-by: Parav Pandit <parav@mellanox.com>
>> ---
>>  include/uapi/linux/devlink.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>> index 3f82dedd..1b412281 100644
>> --- a/include/uapi/linux/devlink.h
>> +++ b/include/uapi/linux/devlink.h
>> @@ -187,6 +187,7 @@ enum devlink_port_flavour {
>>  				      * for the PCI VF. It is an internal
>>  				      * port that faces the PCI VF.
>>  				      */
>> +	DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
>>  };
>>  
>>  enum devlink_param_cmode {
>> @@ -252,6 +253,8 @@ enum devlink_trap_type {
>>  enum {
>>  	/* Trap can report input port as metadata */
>>  	DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
>> +	/* Trap can report flow action cookie as metadata */
>> +	DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
>>  };
>>  
> 
> This hunk doesn't seem relevant to the patch and isn't mentioned in the
> subject or description.
> 
> Thanks,
> Jake

Oops, disregard this. This is just the kernel header update, which is
fine. Just hadn't expected to see it, and it didn't grok the first time
I looked at this.

Thanks,
Jake

Re: [PATCH net-next iproute2 1/2] Update devlink kernel header

[Jacob Keller]

On 3/5/2020 4:43 PM, David Ahern wrote:
> On 3/5/20 5:42 PM, Jacob Keller wrote:
>> This hunk doesn't seem relevant to the patch and isn't mentioned in the
>> subject or description.
> 
> it was a sync of the header file. I drop those changes and do full uapi
> sync for iproute2 and then apply patches.
> 

Makes sense. Thanks for the explanation.