From: Jiri Pirko <jiri@resnulli.us>
To: Edward Cree <ecree@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
saeedm@mellanox.com, leon@kernel.org, michael.chan@broadcom.com,
vishal@chelsio.com, jeffrey.t.kirsher@intel.com,
idosch@mellanox.com, aelior@marvell.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, pablo@netfilter.org,
mlxsw@mellanox.com
Subject: Re: [patch net-next v2 01/12] flow_offload: Introduce offload of HW stats type
Date: Wed, 4 Mar 2020 15:18:39 +0100 [thread overview]
Message-ID: <20200304141839.GD4558@nanopsycho> (raw)
In-Reply-To: <ef1dd85e-dea3-6568-62c9-b363c8cac72b@solarflare.com>
Tue, Mar 03, 2020 at 08:13:23PM CET, ecree@solarflare.com wrote:
>On 28/02/2020 17:24, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Initially, pass "ANY" (struct is zeroed) to the drivers as that is the
>> current implicit value coming down to flow_offload. Add a bool
>> indicating that entries have mixed HW stats type.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>> ---
>> v1->v2:
>> - moved to actions
>> - add mixed bool
>> ---
>> include/net/flow_offload.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>> index 4e864c34a1b0..eee1cbc5db3c 100644
>> --- a/include/net/flow_offload.h
>> +++ b/include/net/flow_offload.h
>> @@ -154,6 +154,10 @@ enum flow_action_mangle_base {
>> FLOW_ACT_MANGLE_HDR_TYPE_UDP,
>> };
>>
>> +enum flow_action_hw_stats_type {
>> + FLOW_ACTION_HW_STATS_TYPE_ANY,
>> +};
>> +
>> typedef void (*action_destr)(void *priv);
>>
>> struct flow_action_cookie {
>> @@ -168,6 +172,7 @@ void flow_action_cookie_destroy(struct flow_action_cookie *cookie);
>>
>> struct flow_action_entry {
>> enum flow_action_id id;
>> + enum flow_action_hw_stats_type hw_stats_type;
>> action_destr destructor;
>> void *destructor_priv;
>> union {
>> @@ -228,6 +233,7 @@ struct flow_action_entry {
>> };
>>
>> struct flow_action {
>> + bool mixed_hw_stats_types;
>Some sort of comment in the commit message the effect that this will
> be set in patch #12 would be nice (and would have saved me some
> reviewing time looking for it ;)
>Strictly speaking this violates SPOT; I know a helper to calculate
> this 'at runtime' in the driver would have to loop over actions,
> but it's control-plane so performance doesn't matter :grin:
That is what I wanted to avoid.
>I'd suggest something like adding an internal-use-only MIXED value to
> the enum, and then having a helper
> enum flow_action_hw_state_type flow_action_single_stats_type(struct flow_action *action);
> which could return FLOW_ACTION_HW_STATS_TYPE_MIXED or else whichever
> type all the actions have (except that the 'different' check might
> be further complicated to ignore DISABLED, since most
> flow_action_entries will be for TC actions with no .update_stats()
> which thus don't want stats and can use DISABLED to express that).
>That then avoids having to rely on the first entry having the stats
> type (so flow_action_first_entry_get() goes away).
No problem. I can call a helper that would go over the entries from
driver. As you say, it is a slow path.
Will do.
>
>-ed
>> unsigned int num_entries;
>> struct flow_action_entry entries[0];
>> };
next prev parent reply other threads:[~2020-03-04 14:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 17:24 [patch net-next v2 00/12] net: allow user specify TC action HW stats type Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 01/12] flow_offload: Introduce offload of " Jiri Pirko
2020-02-29 19:29 ` Pablo Neira Ayuso
2020-03-01 8:44 ` Jiri Pirko
2020-03-02 13:20 ` Pablo Neira Ayuso
2020-03-02 13:58 ` Jiri Pirko
2020-03-02 16:29 ` Edward Cree
2020-03-02 19:24 ` Pablo Neira Ayuso
2020-03-02 20:18 ` Jakub Kicinski
2020-03-02 21:46 ` Pablo Neira Ayuso
2020-03-02 22:49 ` Jakub Kicinski
2020-03-03 17:25 ` Pablo Neira Ayuso
2020-03-03 19:34 ` Jakub Kicinski
2020-03-03 18:55 ` Edward Cree
2020-03-03 19:26 ` Jakub Kicinski
2020-03-03 20:27 ` Pablo Neira Ayuso
2020-03-03 21:06 ` Edward Cree
2020-03-03 21:25 ` Pablo Neira Ayuso
2020-03-03 19:13 ` Edward Cree
2020-03-04 14:18 ` Jiri Pirko [this message]
2020-02-28 17:24 ` [patch net-next v2 02/12] ocelot_flower: use flow_offload_has_one_action() helper Jiri Pirko
2020-02-29 0:50 ` Vladimir Oltean
2020-02-28 17:24 ` [patch net-next v2 03/12] flow_offload: check for basic action hw stats type Jiri Pirko
2020-02-28 19:40 ` Jakub Kicinski
2020-02-29 7:40 ` Jiri Pirko
2020-02-29 19:18 ` Jakub Kicinski
2020-03-01 9:00 ` Jiri Pirko
2020-03-02 19:33 ` Jakub Kicinski
2020-03-03 11:46 ` Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 04/12] mlx5: en_tc: Do not allow mixing HW stats types for actions Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 05/12] mlxsw: spectrum_flower: " Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 06/12] mlx5: restrict supported HW stats type to "any" Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 07/12] mlxsw: " Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 08/12] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw Jiri Pirko
2020-02-29 19:32 ` Pablo Neira Ayuso
2020-03-01 8:47 ` Jiri Pirko
2020-03-02 13:23 ` Pablo Neira Ayuso
2020-03-02 13:59 ` Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 09/12] flow_offload: introduce "delayed" HW stats type and allow it in mlx5 Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 10/12] mlxsw: spectrum_acl: Ask device for rule stats only if counter was created Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 11/12] flow_offload: introduce "disabled" HW stats type and allow it in mlxsw Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 12/12] sched: act: allow user to specify type of HW stats for a filter Jiri Pirko
2020-02-28 19:59 ` Jakub Kicinski
2020-02-29 7:52 ` Jiri Pirko
2020-02-29 20:14 ` Jakub Kicinski
2020-03-01 8:57 ` Jiri Pirko
2020-03-02 19:39 ` Jakub Kicinski
2020-03-03 13:20 ` Jiri Pirko
2020-03-03 19:48 ` Jakub Kicinski
2020-03-04 8:15 ` Jiri Pirko
2020-03-03 19:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304141839.GD4558@nanopsycho \
--to=jiri@resnulli.us \
--cc=aelior@marvell.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).