* [PATCH] rhashtable: Document the right function parameters
@ 2020-03-05 16:05 Jonathan Neuschäfer
2020-03-06 0:26 ` Herbert Xu
2020-03-07 6:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2020-03-05 16:05 UTC (permalink / raw)
To: netdev; +Cc: Jonathan Neuschäfer, Thomas Graf, Herbert Xu, linux-kernel
rhashtable_lookup_get_insert_key doesn't have a parameter `data`. It
does have a parameter `key`, however.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
include/linux/rhashtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index beb9a9da1699..70ebef866cc8 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -972,9 +972,9 @@ static inline int rhashtable_lookup_insert_key(
/**
* rhashtable_lookup_get_insert_key - lookup and insert object into hash table
* @ht: hash table
+ * @key: key
* @obj: pointer to hash head inside object
* @params: hash table parameters
- * @data: pointer to element data already in hashes
*
* Just like rhashtable_lookup_insert_key(), but this function returns the
* object if it exists, NULL if it does not and the insertion was successful,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rhashtable: Document the right function parameters
2020-03-05 16:05 [PATCH] rhashtable: Document the right function parameters Jonathan Neuschäfer
@ 2020-03-06 0:26 ` Herbert Xu
2020-03-07 6:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-03-06 0:26 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: netdev, Thomas Graf, linux-kernel
On Thu, Mar 05, 2020 at 05:05:16PM +0100, Jonathan Neuschäfer wrote:
> rhashtable_lookup_get_insert_key doesn't have a parameter `data`. It
> does have a parameter `key`, however.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rhashtable: Document the right function parameters
2020-03-05 16:05 [PATCH] rhashtable: Document the right function parameters Jonathan Neuschäfer
2020-03-06 0:26 ` Herbert Xu
@ 2020-03-07 6:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-07 6:33 UTC (permalink / raw)
To: j.neuschaefer; +Cc: netdev, tgraf, herbert, linux-kernel
From: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Date: Thu, 5 Mar 2020 17:05:16 +0100
> rhashtable_lookup_get_insert_key doesn't have a parameter `data`. It
> does have a parameter `key`, however.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-07 6:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 16:05 [PATCH] rhashtable: Document the right function parameters Jonathan Neuschäfer
2020-03-06 0:26 ` Herbert Xu
2020-03-07 6:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).