[PATCH] net: dsa: mt7530: fix macro MIRROR_PORT

[PATCH] net: dsa: mt7530: fix macro MIRROR_PORT

[DENG Qingfang]

The inner pair of parentheses should be around the variable x
Fixes: 37feab6076aa ("net: dsa: mt7530: add support for port mirroring")

Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
 drivers/net/dsa/mt7530.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h
index 5e6c778..b7cfb3d 100644
--- a/drivers/net/dsa/mt7530.h
+++ b/drivers/net/dsa/mt7530.h
@@ -37,7 +37,7 @@ enum {
 #define  CPU_PORT(x)			((x) << 4)
 #define  CPU_MASK			(0xf << 4)
 #define  MIRROR_EN			BIT(3)
-#define  MIRROR_PORT(x)			((x & 0x7))
+#define  MIRROR_PORT(x)			((x) & 0x7)
 #define  MIRROR_MASK			0x7
 
 /* Registers for address table access */
-- 
2.25.1

Re: [PATCH] net: dsa: mt7530: fix macro MIRROR_PORT

[David Miller]

From: DENG Qingfang <dqfext@gmail.com>
Date: Wed, 11 Mar 2020 02:20:50 +0800

> The inner pair of parentheses should be around the variable x
> Fixes: 37feab6076aa ("net: dsa: mt7530: add support for port mirroring")
> 
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>

Two things:

1) In the Subject line always indicate the target tree for your changes.
   This case would be net-next since that is the only tree where the
   Fixes: tag commit exists, thus "Subject: [PATCH net-next] ..."

2) Always group the various tags together into a contiguous series of
   lines of text, starting the the Fixes tag.  Make sure there is an
   empty line between the commit message description text, and the tags.

I fixes it up for you this time, but next time I will not and push back
for you to fix it up yourself.

Applied to net-next, thank you.