* [PATCH -next] net: ibm: remove set but not used variables 'err'
@ 2020-03-11 6:54 Chen Zhou
2020-03-12 6:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-03-11 6:54 UTC (permalink / raw)
To: davem; +Cc: willy, andrew, hkallweit1, kuba, netdev, linux-kernel, chenzhou10
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
variable err set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/ethernet/ibm/emac/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index b7fc177..06248a7 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -872,7 +872,7 @@ static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
{
struct emac_regs __iomem *p = dev->emacp;
u32 r = 0;
- int n, err = -ETIMEDOUT;
+ int n;
mutex_lock(&dev->mdio_lock);
@@ -919,7 +919,6 @@ static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
goto bail;
}
}
- err = 0;
bail:
if (emac_has_feature(dev, EMAC_FTR_HAS_RGMII))
rgmii_put_mdio(dev->rgmii_dev, dev->rgmii_port);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ibm: remove set but not used variables 'err'
2020-03-11 6:54 [PATCH -next] net: ibm: remove set but not used variables 'err' Chen Zhou
@ 2020-03-12 6:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-03-12 6:33 UTC (permalink / raw)
To: chenzhou10; +Cc: willy, andrew, hkallweit1, kuba, netdev, linux-kernel
From: Chen Zhou <chenzhou10@huawei.com>
Date: Wed, 11 Mar 2020 14:54:11 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
> drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
> variable err set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 6:54 [PATCH -next] net: ibm: remove set but not used variables 'err' Chen Zhou
2020-03-12 6:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).