* [PATCH v1] ARM: dts: imx6dl-riotboard: properly define rgmii PHY
@ 2020-03-04 6:54 Oleksij Rempel
2020-03-11 8:45 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2020-03-04 6:54 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, David S. Miller, devicetree, Fabio Estevam,
Liam Girdwood, linux-arm-kernel, linux-kernel, Mark Brown,
netdev, NXP Linux Team, Pengutronix Kernel Team, Russell King
The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-riotboard.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 829654e1835a..17c637b66387 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -89,11 +89,27 @@ &fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
phy-mode = "rgmii-id";
- phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ phy-handle = <&rgmii_phy>;
interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
<&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
fsl,err006687-workaround-present;
status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Atheros AR8035 PHY */
+ rgmii_phy: ethernet-phy@4 {
+ reg = <4>;
+
+ interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+
+ reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <1000>;
+ };
+ };
};
&gpio1 {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ARM: dts: imx6dl-riotboard: properly define rgmii PHY
2020-03-04 6:54 [PATCH v1] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
@ 2020-03-11 8:45 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-03-11 8:45 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, David S. Miller, devicetree,
Fabio Estevam, Liam Girdwood, linux-arm-kernel, linux-kernel,
Mark Brown, netdev, NXP Linux Team, Pengutronix Kernel Team,
Russell King
On Wed, Mar 04, 2020 at 07:54:36AM +0100, Oleksij Rempel wrote:
> The Atheros AR8035 PHY can be autodetected but can't use interrupt
> support provided on this board. Define MDIO bus and the PHY node to make
> it work properly.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6dl-riotboard.dts | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 829654e1835a..17c637b66387 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -89,11 +89,27 @@ &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rgmii-id";
> - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> + phy-handle = <&rgmii_phy>;
> interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> fsl,err006687-workaround-present;
> status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Atheros AR8035 PHY */
> + rgmii_phy: ethernet-phy@4 {
> + reg = <4>;
> +
> + interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
> +
Drop these unnecessary newlines.
Shawn
> + reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <1000>;
> + };
> + };
> };
>
> &gpio1 {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 6:54 [PATCH v1] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
2020-03-11 8:45 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).