* [PATCH net] r8169: re-enable MSI on RTL8168c
@ 2020-03-24 19:58 Heiner Kallweit
2020-03-25 0:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2020-03-24 19:58 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev
The original change fixed an issue on RTL8168b by mimicking the vendor
driver behavior to disable MSI on chip versions before RTL8168d.
This however now caused an issue on a system with RTL8168c, see [0].
Therefore leave MSI disabled on RTL8168b, but re-enable it on RTL8168c.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1792839
Fixes: 003bd5b4a7b4 ("r8169: don't use MSI before RTL8168d")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index b7dc1c112..7949ec63a 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5091,7 +5091,7 @@ static int rtl_alloc_irq(struct rtl8169_private *tp)
RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~MSIEnable);
rtl_lock_config_regs(tp);
/* fall through */
- case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_24:
+ case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_17:
flags = PCI_IRQ_LEGACY;
break;
default:
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] r8169: re-enable MSI on RTL8168c
2020-03-24 19:58 [PATCH net] r8169: re-enable MSI on RTL8168c Heiner Kallweit
@ 2020-03-25 0:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-03-25 0:21 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 24 Mar 2020 20:58:29 +0100
> The original change fixed an issue on RTL8168b by mimicking the vendor
> driver behavior to disable MSI on chip versions before RTL8168d.
> This however now caused an issue on a system with RTL8168c, see [0].
> Therefore leave MSI disabled on RTL8168b, but re-enable it on RTL8168c.
>
> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1792839
>
> Fixes: 003bd5b4a7b4 ("r8169: don't use MSI before RTL8168d")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-25 0:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 19:58 [PATCH net] r8169: re-enable MSI on RTL8168c Heiner Kallweit
2020-03-25 0:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).